All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Baptiste Le Duc <baptiste.le-duc@vates.tech>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] xen/riscv: bound each IMSIC MMIO regset by the per-group hart slots
Date: Mon, 16 Nov 2026 17:50:16 +0100	[thread overview]
Message-ID: <83f59bf3-89a9-400a-a34b-ff14f27c97ca@suse.com> (raw)
In-Reply-To: <1794847326.8631fc262581453bbf619ec5b2062170.1a1e53cc2430006d3f@vates.tech>

On 16.11.2026 17:42, Baptiste Le Duc wrote:
> On 11/16/26 5:34 PM, Oleksii Kurochko wrote:
> 
>>> -        if ( mmios[i].size != expected_mmio_size )
>>> +        /* A register set must not run past the end of its group. */
>>> +        offset = mmios[i].base_addr & (group_size - 1);
>>> +        if ( mmios[i].size + offset > group_size )
>>
>> This can overflow for a bogus, huge size from the DT and then pass. As 
>> offset is always below group_size,
> Oh yeah, thanks.
>>
>>          if ( mmios[i].size > group_size - offset )
>>
>> can't.
> Jan, do you think it needs a new version for this overflow?

I can do this adjustment as well while committing.

Jan


      reply	other threads:[~2026-11-16 16:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 15:29 [PATCH v2] xen/riscv: bound each IMSIC MMIO regset by the per-group hart slots Baptiste Le Duc
2026-11-16 15:36 ` Jan Beulich
2026-11-16 15:45   ` Baptiste Le Duc
2026-11-16 15:47     ` Jan Beulich
2026-11-16 16:32 ` Oleksii Kurochko
2026-11-16 16:42   ` Baptiste Le Duc
2026-11-16 16:50     ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83f59bf3-89a9-400a-a34b-ff14f27c97ca@suse.com \
    --to=jbeulich@suse.com \
    --cc=baptiste.le-duc@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.