From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1AB6C5DF66 for ; Mon, 17 Aug 2026 15:20:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F5BB10E85C; Mon, 17 Aug 2026 15:20:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="gMOkiJJD"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8FAD010E856 for ; Mon, 17 Aug 2026 15:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:From:Cc:To:Subject: MIME-Version:Date:Message-ID:From:Reply-To; bh=ZxcKn0BzYAqkhhZC/v9g9+rFXa59xFYbuEtp8+Atg9A=; b=gMOkiJJDb5FTWTzIsleH7fs55L NqprWwWAYqGLxFjVb1JwIZHxlkig/eGiEw13nOa6r1j9oEGrinpb4ulu1s5qCBwSv/UKAY9bxXIQA ak0muTILEfFjEzUbKitjd4iVeZ99TJDgvEBj2NiRlTHRGSElipeEIRYP86FkCUTRsyxK5fjIsOnEP V/QseWi2a9qbDQtvzkGO4cTMu3lZxpG1yuv5ymyFfH2tt0L1I/uT2c6SgF+VjIwzC8NCd8ZUwBBDN b3RCy1WJJsWFgDtfOUP1Ey+VYVDtvSFMuguKtiOzuxk7jm6d5DZ7dBOn0Fi1TROUuMOz3ocWdqIZW MLhijK7w==; Received: from 154.red-79-147-121.dynamicip.rima-tde.net ([79.147.121.154] helo=[192.168.1.202]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1wvz7V-004ewk-Oj; Mon, 17 Aug 2026 17:19:25 +0200 Message-ID: <83fb4a66-cf7a-4ebb-be39-d3f51da4baa6@igalia.com> Date: Mon, 17 Aug 2026 17:19:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t v3 6/6] tests/kms_color_pipeline: skip if not an intel device To: Alex Hung , Petri Latvala , Arkadiusz Hiler , Kamil Konieczny , Juha-Pekka Heikkila , Bhanuprakash Modem , Ashutosh Dixit , Karthik B S Cc: Chaitanya Kumar Borah , igt-dev@lists.freedesktop.org, kernel-dev@igalia.com, Swati Sharma , John Harrison , Rodrigo Siqueira , Simon Ser , Xaver Hugl , Harry Wentland , Uma Shankar References: <20260811143558.141813-1-mwen@igalia.com> <20260811143558.141813-7-mwen@igalia.com> <62e1b4a3-ba46-4117-a3e3-05f9866aa614@amd.com> Content-Language: en-US From: Melissa Wen In-Reply-To: <62e1b4a3-ba46-4117-a3e3-05f9866aa614@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On 14/08/2026 05:55, Alex Hung wrote: > > > On 8/11/26 08:23, Melissa Wen wrote: >>  From documentation, the test requires i915 or xe driver, so make >> sure it >> only runs with intel devices. In addition, it's a CRC-based test, making > Should this test be moved to tests/intel/? I kept it as a KMS test because kms_colorop relies on writeback support, but writeback isn't present in many drivers AFAIK. So these CRC tests can be used by other drivers if they don't support writeback but support colorop. Melissa > >> kms_colorop with writeback more aligned with color testing and >> validation. Other drivers should work on adapting this test to their >> needs if they are looking for CRC validation. >> >> Reviewed-by: Chaitanya Kumar Borah >> Signed-off-by: Melissa Wen >> --- >>   tests/kms_color_pipeline.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/tests/kms_color_pipeline.c b/tests/kms_color_pipeline.c >> index 78860a845..3978745a5 100644 >> --- a/tests/kms_color_pipeline.c >> +++ b/tests/kms_color_pipeline.c >> @@ -372,6 +372,7 @@ int igt_main() >>           igt_display_require(&data.display, data.drm_fd); >>           data.display.has_plane_color_pipeline = >> has_plane_color_pipeline; >>           igt_require(data.display.is_atomic); >> +        igt_require(is_intel_device(data.drm_fd)); >>       } >>         igt_subtest_group() >