All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannu Koivisto <azure@iki.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: Charles Bailey <charles@hashpling.org>,
	git@vger.kernel.org, Theodore Tso <tytso@mit.edu>
Subject: Re: [PATCH] mergetool: respect autocrlf by using checkout-index
Date: Tue, 27 Jan 2009 15:58:21 +0200	[thread overview]
Message-ID: <83ocxsetqa.fsf@kalahari.s2.org> (raw)
In-Reply-To: <7vocxt3bsc.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 26 Jan 2009 15:09:07 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Perhaps something along this line to teach
>>
>>     $ git merge-file --attribute-path=frotz.c file1 orig_file file2
>>
>> to merge what happened since orig_file to file2 into file1, and deposit
>> the result after converting it appropriately for path "frotz.c" obeying
>> core.autocrlf and gitattribute rules.
>>
>> I see rerere.c::merge() has the exact same issue, but its breakage is half
>> hidden by its use of fopen(path, "w").  It should explicitly use
>> convert_to_working_tree() like this patch does, and write the results out
>> in binary mode.
>
> Second try.  I forgot how convert_* worked X-<.

Argh, it seems I have wasted your time.  That patch may do
something useful but in this case with _or without_ it all the
files seem to be correct in the filesystem before I save the merge
result in emerge.  I.e. it seems that for some reason Emacs detects
the coding system of the result file incorrectly.  I'll investigate
that at some point especially if ediff suffers from the same
problem.

-- 
Hannu

      reply	other threads:[~2009-01-27 13:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 16:55 git diff, git mergetool and CRLF conversion Hannu Koivisto
2009-01-21 17:23 ` Charles Bailey
2009-01-21 21:03   ` Theodore Tso
2009-01-21 22:57     ` [PATCH] mergetool: respect autocrlf by using checkout-index Charles Bailey
2009-01-23 17:20       ` Junio C Hamano
2009-01-23 18:18         ` Charles Bailey
2009-01-26 16:15         ` Hannu Koivisto
2009-01-26 16:31           ` Charles Bailey
2009-01-26 21:28             ` Junio C Hamano
2009-01-26 22:08               ` Junio C Hamano
2009-01-26 23:09                 ` Junio C Hamano
2009-01-27 13:58                   ` Hannu Koivisto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ocxsetqa.fsf@kalahari.s2.org \
    --to=azure@iki.fi \
    --cc=charles@hashpling.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.