All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Douglas Anderson" <dianders@chromium.org>,
	linux-samsung-soc@vger.kernel.org,
	"Lin Huang" <hl@rock-chips.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	dri-devel@lists.freedesktop.org,
	"Tomasz Figa" <tfiga@chromium.org>,
	linux-rockchip@lists.infradead.org,
	"Thierry Escande" <thierry.escande@collabora.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Stéphane Marchesin" <marcheu@chromium.org>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Caesar Wang" <wxt@rock-chips.com>,
	"Zain Wang" <wzz@rock-chips.com>,
	"Haixia Shi" <hshi@chromium.org>
Subject: Re: [PATCH 1/3] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind
Date: Mon, 05 Mar 2018 13:39:29 +0100	[thread overview]
Message-ID: <8401762.TthTLs8B3o@diego> (raw)
In-Reply-To: <20180305085741.18896-2-m.szyprowski@samsung.com>

Am Montag, 5. März 2018, 09:57:39 CET schrieb Marek Szyprowski:
> From: zain wang <wzz@rock-chips.com>
> 
> The bridge does not need to be powered in analogix_dp_bind(), so
> remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp()
> as well as their power-off counterparts.
> 
> Cc: Stéphane Marchesin <marcheu@chromium.org>
> Signed-off-by: zain wang <wzz@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> [the patch originally just removed the power_on portion, seanpaul removed
> the power off code as well as improved the commit message]
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

on top of current drm-misc-next on rk3288 and rk3399
Tested-by: Heiko Stuebner <heiko@sntech.de>

and the actual change also looks sane of course, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-03-05 12:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180305085803eucas1p2ff8ab6037f5158ab338bfe5e6d7d8ccd@eucas1p2.samsung.com>
2018-03-05  8:57 ` [PATCH 0/3] Analogix DP fixes for Chromebook2 Peach-Pit (Exynos5420) Marek Szyprowski
2018-03-05  8:57   ` [PATCH 1/3] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind Marek Szyprowski
2018-03-05 12:39     ` Heiko Stübner [this message]
2018-03-05  8:57   ` [PATCH 2/3] drm/bridge: analogix_dp: Postpone enabling runtime power management Marek Szyprowski
2018-03-05 12:44     ` Heiko Stübner
2018-03-05  8:57   ` [PATCH 3/3] drm/bridge: analogix_dp: Don't create useless connectors Marek Szyprowski
2018-03-05 12:46     ` Heiko Stübner
2018-03-07 15:31   ` [PATCH 0/3] Analogix DP fixes for Chromebook2 Peach-Pit (Exynos5420) Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8401762.TthTLs8B3o@diego \
    --to=heiko@sntech.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=enric.balletbo@collabora.com \
    --cc=hl@rock-chips.com \
    --cc=hshi@chromium.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marcheu@chromium.org \
    --cc=tfiga@chromium.org \
    --cc=thierry.escande@collabora.com \
    --cc=thierry.reding@gmail.com \
    --cc=wxt@rock-chips.com \
    --cc=wzz@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.