From: Michael Schmitz <schmitzmic@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
linux-m68k@vger.kernel.org, geert@linux-m68k.org,
martin@lichtvoll.de, fthain@linux-m68k.org,
stable@vger.kernel.org
Subject: Re: [PATCH v10 2/3] block: change annotation of rdb_CylBlocks in affs_hardblocks.h
Date: Thu, 15 Jun 2023 19:09:31 +1200 [thread overview]
Message-ID: <841007d6-65f8-6635-6b57-9dcd68fab017@gmail.com> (raw)
In-Reply-To: <20230615055349.GA5544@lst.de>
Hi Christoph,
Am 15.06.2023 um 17:53 schrieb Christoph Hellwig:
> On Thu, Jun 15, 2023 at 04:50:45PM +1200, Michael Schmitz wrote:
>>> And as far as I can tell everything that is a __u32 here should
>>> be an __be32 because it is a big endian on-disk format. Why
>>> would you change only a single field?
>>
>> Because that's all I needed, and wanted to avoid excess patch churn. Plus
>> (appeal to authority here :-)) it's in keeping with what Al Viro did when
>> the __be32 annotations were first added.
>>
>> I can change all __u32 to __be32 and drop the comment if that's preferred.
>
> That would be great!
OK, will respin tomorrow.
Cheers,
Michael
next prev parent reply other threads:[~2023-06-15 7:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 3:08 [PATCH v10 0/3] Amiga RDB partition support fixes Michael Schmitz
2023-06-15 3:08 ` [PATCH v10 1/3] block: fix signed int overflow in Amiga partition support Michael Schmitz
2023-06-15 3:08 ` [PATCH v10 2/3] block: change annotation of rdb_CylBlocks in affs_hardblocks.h Michael Schmitz
2023-06-15 4:17 ` Christoph Hellwig
2023-06-15 4:50 ` Michael Schmitz
2023-06-15 5:53 ` Christoph Hellwig
2023-06-15 7:09 ` Michael Schmitz [this message]
2023-06-15 7:21 ` Geert Uytterhoeven
2023-06-15 19:53 ` Michael Schmitz
2023-06-16 5:48 ` Christoph Hellwig
2023-06-16 7:20 ` Michael Schmitz
2023-06-16 7:25 ` Christoph Hellwig
2023-06-16 7:51 ` Michael Schmitz
2023-06-16 7:28 ` Geert Uytterhoeven
2023-06-16 7:45 ` Michael Schmitz
2023-06-15 3:08 ` [PATCH v10 3/3] block: add overflow checks for Amiga partition support Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841007d6-65f8-6635-6b57-9dcd68fab017@gmail.com \
--to=schmitzmic@gmail.com \
--cc=axboe@kernel.dk \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=martin@lichtvoll.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.