From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4D57C636D3 for ; Tue, 31 Jan 2023 02:54:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F19D18580C; Tue, 31 Jan 2023 03:53:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 718C285813; Tue, 31 Jan 2023 03:53:56 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 79BB8857A4 for ; Tue, 31 Jan 2023 03:53:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id D0F043C01CE; Tue, 31 Jan 2023 10:53:38 +0800 (CST) Message-ID: <841474fb-0cdc-cd13-8d7a-4dc4dd16626e@rock-chips.com> Date: Tue, 31 Jan 2023 10:53:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] Revert "rockchip: Only call binman when TPL available" Content-Language: en-US To: Jagan Teki , Tom Rini , Simon Glass Cc: u-boot@lists.denx.de, Quentin Schulz References: <20230127072133.852818-1-jagan@edgeble.ai> From: Kever Yang In-Reply-To: <20230127072133.852818-1-jagan@edgeble.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVlCHR5JVkIdSE9MGUlNSktPHVUTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVSktLVUtZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PDo6Izo5Tj0WPj9CMRMJDTFN S0hPFDpVSlVKTUxOSkhITUpCSEhDVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFISkxMNwY+ X-HM-Tid: 0a8605be8b202eb0kusnd0f043c01ce X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi     I think I do this modify for those soc not have TPL, or else it will cause the CI build error. TPL/ddr binary is mandatory in all rockchip SoCs now, but the mainline U-Boot may not able to provide the the available TPL, will need ddr init binary from rockchip rkbin repository instead. So the policy is clear, the binary output on mainline U-Boot rockchip platform: - TPL available: u-boot-rockchip.bin with TPL, SPL, ATF, U-Boot proper; - TPL not available: u-boot.itb with ATF, U-Boot proper.                                         idbloader.bin generate by the TPL(ddr init binary instead) and SPL via mkimage cmd; Thanks, - Kever On 2023/1/27 15:21, Jagan Teki wrote: > This reverts commit f5315dd6290a588434e4f79bfd2886bb7df9210d. > > [why] > TPL is not mandatory for not all Rockchip SoCs, some SoCs like > RK356x, and RK3588 still use mainline u-boot without TPL as > their ddr init programs are accessed via binaries provided by > Rockchip instead of ddr source code. > > Marking TPL build makes it not able to build u-boot.itb on > RK356x targets so revert this so that it can build an SPL build > that would support all across Rockchip platforms. > > Suggested-by: Quentin Schulz > Signed-off-by: Jagan Teki > --- > arch/arm/dts/rockchip-u-boot.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi > index 234fc5df43..6d1fd7769e 100644 > --- a/arch/arm/dts/rockchip-u-boot.dtsi > +++ b/arch/arm/dts/rockchip-u-boot.dtsi > @@ -11,7 +11,7 @@ > }; > }; > > -#ifdef CONFIG_TPL > +#ifdef CONFIG_SPL > &binman { > simple-bin { > filename = "u-boot-rockchip.bin";