Re: [PATCH net-next 4/5] net: bcmasp: Add support for asp-v3.0

[Florian Fainelli <florian.fainelli@broadcom.com>]

On 4/16/25 15:48, Justin Chen wrote:
> The asp-v3.0 is a major HW revision that reduced the number of
> channels and filters. The goal was to save cost by reducing the
> feature set.
> 
> Changes for asp-v3.0
> - Number of network filters were reduced.
> - Number of channels were reduced.
> - EDPKT stats were removed.
> - Fix a bug with csum offload.
> 
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> ---

[snip]

>   MODULE_DEVICE_TABLE(of, bcmasp_mdio_of_match);
> @@ -1285,6 +1310,17 @@ static int bcmasp_probe(struct platform_device *pdev)
>   	 * how many interfaces come up.
>   	 */
>   	bcmasp_core_init(priv);
> +
> +	priv->mda_filters = devm_kzalloc(dev, sizeof(*priv->mda_filters)
> +					 * priv->num_mda_filters, GFP_KERNEL);

Nit: those are candidates for devm_kcalloc().

> +	if (!priv->mda_filters)
> +		return -ENOMEM;
> +
> +	priv->net_filters = devm_kzalloc(dev, sizeof(*priv->net_filters)
> +					 * priv->num_net_filters, GFP_KERNEL);

Likewise.

-- 
Florian