From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:58463 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbeAOUce (ORCPT ); Mon, 15 Jan 2018 15:32:34 -0500 From: Laurent Pinchart To: Sergei Shtylyov Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver Date: Mon, 15 Jan 2018 22:32:38 +0200 Message-ID: <84235223.mW0iJ7b1HL@avalon> In-Reply-To: <9a2806f3-d232-b587-bc77-733e9d45c138@cogentembedded.com> References: <20180112231430.26943-1-laurent.pinchart+renesas@ideasonboard.com> <20180112231430.26943-5-laurent.pinchart+renesas@ideasonboard.com> <9a2806f3-d232-b587-bc77-733e9d45c138@cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, On Monday, 15 January 2018 22:25:16 EET Sergei Shtylyov wrote: > On 01/13/2018 02:14 AM, Laurent Pinchart wrote: > > The LVDS encoders used to be described in DT as part of the DU. They now > > have their own DT node, linked to the DU using the OF graph bindings. > > This allows moving internal LVDS encoder support to a separate driver > > modelled as a DRM bridge. Backward compatibility is retained as legacy > > DT is patched live to move to the new bindings. > > > > Signed-off-by: Laurent Pinchart > > > > [...] > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 6e02c762a557..06a3fbdd728a > > 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > [...] > > > /* -------------------------------------------------------------------- > > @@ -74,7 +75,6 @@ static const struct rcar_du_device_info > > rzg1_du_r8a7745_info = { > > .port = 1, > }, > > }, > > - .num_lvds = 0, > > }; > > > > static const struct rcar_du_device_info rcar_du_r8a7779_info = { > > @@ -95,14 +95,13 @@ static const struct rcar_du_device_info > > rcar_du_r8a7779_info = { > > .port = 1, > > }, > > }, > > - .num_lvds = 0, > > }; > > > > static const struct rcar_du_device_info rcar_du_r8a7790_info = { > > .gen = 2, > > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > > | RCAR_DU_FEATURE_EXT_CTRL_REGS, > > - .quirks = RCAR_DU_QUIRK_ALIGN_128B | RCAR_DU_QUIRK_LVDS_LANES, > > + .quirks = RCAR_DU_QUIRK_ALIGN_128B, > > .num_crtcs = 3, > > .routes = { > > /* > > @@ -164,7 +163,6 @@ static const struct rcar_du_device_info > > rcar_du_r8a7792_info = { > > .port = 1, > > }, > > }, > > - .num_lvds = 0, > > }; > > > > static const struct rcar_du_device_info rcar_du_r8a7794_info = { > > @@ -186,7 +184,6 @@ static const struct rcar_du_device_info > > rcar_du_r8a7794_info = { > > .port = 1, > > }, > > }, > > - .num_lvds = 0, > > I think you can remove *all* such initializers and the field itself with > them -- otherwise it looks like you're doing a not-quite-related drive-by > clean up... The OF compatibility code uses the .num_lvds field, that's why I haven't removed it. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver Date: Mon, 15 Jan 2018 22:32:38 +0200 Message-ID: <84235223.mW0iJ7b1HL@avalon> References: <20180112231430.26943-1-laurent.pinchart+renesas@ideasonboard.com> <20180112231430.26943-5-laurent.pinchart+renesas@ideasonboard.com> <9a2806f3-d232-b587-bc77-733e9d45c138@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDA6B6E15B for ; Mon, 15 Jan 2018 20:32:34 +0000 (UTC) In-Reply-To: <9a2806f3-d232-b587-bc77-733e9d45c138@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2VyZ2VpLAoKT24gTW9uZGF5LCAxNSBKYW51YXJ5IDIwMTggMjI6MjU6MTYgRUVUIFNlcmdl aSBTaHR5bHlvdiB3cm90ZToKPiBPbiAwMS8xMy8yMDE4IDAyOjE0IEFNLCBMYXVyZW50IFBpbmNo YXJ0IHdyb3RlOgo+ID4gVGhlIExWRFMgZW5jb2RlcnMgdXNlZCB0byBiZSBkZXNjcmliZWQgaW4g RFQgYXMgcGFydCBvZiB0aGUgRFUuIFRoZXkgbm93Cj4gPiBoYXZlIHRoZWlyIG93biBEVCBub2Rl LCBsaW5rZWQgdG8gdGhlIERVIHVzaW5nIHRoZSBPRiBncmFwaCBiaW5kaW5ncy4KPiA+IFRoaXMg YWxsb3dzIG1vdmluZyBpbnRlcm5hbCBMVkRTIGVuY29kZXIgc3VwcG9ydCB0byBhIHNlcGFyYXRl IGRyaXZlcgo+ID4gbW9kZWxsZWQgYXMgYSBEUk0gYnJpZGdlLiBCYWNrd2FyZCBjb21wYXRpYmls aXR5IGlzIHJldGFpbmVkIGFzIGxlZ2FjeQo+ID4gRFQgaXMgcGF0Y2hlZCBsaXZlIHRvIG1vdmUg dG8gdGhlIG5ldyBiaW5kaW5ncy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5j aGFydAo+ID4gPGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+IAo+ IFsuLi5dCj4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9k dV9kcnYuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jIGluZGV4 IDZlMDJjNzYyYTU1Ny4uMDZhM2ZiZGQ3MjhhCj4gPiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9y Y2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiAKPiBbLi4uXQo+IAo+ID4gICAvKiAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4gQEAgLTc0LDcgKzc1LDYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCByY2FyX2R1X2RldmljZV9p bmZvCj4gPiByemcxX2R1X3I4YTc3NDVfaW5mbyA9IHsKPiA+ICAgCQkJLnBvcnQgPSAxLAogPiAg IAkJfSwKPiA+ICAgCX0sCj4gPiAtCS5udW1fbHZkcyA9IDAsCj4gPiAgIH07Cj4gPiAgIAo+ID4g ICBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8gcmNhcl9kdV9yOGE3Nzc5 X2luZm8gPSB7Cj4gPiBAQCAtOTUsMTQgKzk1LDEzIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNh cl9kdV9kZXZpY2VfaW5mbwo+ID4gcmNhcl9kdV9yOGE3Nzc5X2luZm8gPSB7Cj4gPiAgIAkJCS5w b3J0ID0gMSwKPiA+ICAgCQl9LAo+ID4gICAJfSwKPiA+IC0JLm51bV9sdmRzID0gMCwKPiA+ICAg fTsKPiA+ICAgCj4gPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2VfaW5mbyBy Y2FyX2R1X3I4YTc3OTBfaW5mbyA9IHsKPiA+ICAgCS5nZW4gPSAyLAo+ID4gICAJLmZlYXR1cmVz ID0gUkNBUl9EVV9GRUFUVVJFX0NSVENfSVJRX0NMT0NLCj4gPiAgIAkJICB8IFJDQVJfRFVfRkVB VFVSRV9FWFRfQ1RSTF9SRUdTLAo+ID4gLQkucXVpcmtzID0gUkNBUl9EVV9RVUlSS19BTElHTl8x MjhCIHwgUkNBUl9EVV9RVUlSS19MVkRTX0xBTkVTLAo+ID4gKwkucXVpcmtzID0gUkNBUl9EVV9R VUlSS19BTElHTl8xMjhCLAo+ID4gICAJLm51bV9jcnRjcyA9IDMsCj4gPiAgIAkucm91dGVzID0g ewo+ID4gICAJCS8qCj4gPiBAQCAtMTY0LDcgKzE2Myw2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg cmNhcl9kdV9kZXZpY2VfaW5mbwo+ID4gcmNhcl9kdV9yOGE3NzkyX2luZm8gPSB7Cj4gPiAgIAkJ CS5wb3J0ID0gMSwKPiA+ICAgCQl9LAo+ID4gICAJfSwKPiA+IC0JLm51bV9sdmRzID0gMCwKPiA+ ICAgfTsKPiA+ICAgCj4gPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2VfaW5m byByY2FyX2R1X3I4YTc3OTRfaW5mbyA9IHsKPiA+IEBAIC0xODYsNyArMTg0LDYgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCByY2FyX2R1X2RldmljZV9pbmZvCj4gPiByY2FyX2R1X3I4YTc3OTRfaW5m byA9IHsKPiA+ICAgCQkJLnBvcnQgPSAxLAo+ID4gICAJCX0sCj4gPiAgIAl9LAo+ID4gLQkubnVt X2x2ZHMgPSAwLAo+IAo+IEkgdGhpbmsgeW91IGNhbiByZW1vdmUgKmFsbCogc3VjaCBpbml0aWFs aXplcnMgYW5kIHRoZSBmaWVsZCBpdHNlbGYgd2l0aAo+IHRoZW0gLS0gb3RoZXJ3aXNlIGl0IGxv b2tzIGxpa2UgeW91J3JlIGRvaW5nIGEgbm90LXF1aXRlLXJlbGF0ZWQgZHJpdmUtYnkKPiBjbGVh biB1cC4uLgoKVGhlIE9GIGNvbXBhdGliaWxpdHkgY29kZSB1c2VzIHRoZSAubnVtX2x2ZHMgZmll bGQsIHRoYXQncyB3aHkgSSBoYXZlbid0IApyZW1vdmVkIGl0LgoKLS0gClJlZ2FyZHMsCgpMYXVy ZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK