From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone Date: Sun, 18 Nov 2018 22:56:41 +0100 Message-ID: <8430826.3j7pgKI0Cq@xps> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> <2601191342CEEE43887BDE71AB977258010CE49D0D@IRSMSX106.ger.corp.intel.com> <3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, "Wang, Dong1" , "Ananyev, Konstantin" , "dev@dpdk.org" , "Burakov, Anatoly" To: "Lipiec, Herakliusz" Return-path: In-Reply-To: <3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > The ipv4_multicast sample application was dropping packets when using > > mbuf clone. When creating an L2 header and copying metadata from the > > source packet, the ol_flags were also copied along with all the other > > metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in > > its ol_flags, this caused the packets to never be freed when using > > rte_pktmbuf_free. > > Since copying ol_flags from the cloned packet is not necessary in the > > first place, just don't do it. > > > > Fixes: af75078fece3 ("first public release") > > CC: stable@dpdk.org > > > > Reported-by: Wang Dong > > Signed-off-by: Herakliusz Lipiec > > Acked-by: Konstantin Ananyev > Acked-by: Wang Dong Applied, thanks