Re: [XEN PATCH][for-4.19] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

[Nicola Vetrini <nicola.vetrini@bugseng.com>]

On 2023-11-07 10:49, Julien Grall wrote:
> Hi,
> 
> On 07/11/2023 08:36, Nicola Vetrini wrote:
>> On 2023-11-06 23:57, Julien Grall wrote:
>>> Hi Nicola,
>>> 
>>> On 03/11/2023 18:05, Nicola Vetrini wrote:
>>>> The comment-based justifications for MISRA C:2012 Rule 8.4 are 
>>>> replaced
>>>> by the asmlinkage pseudo-attribute, for the sake of uniformity.
>>>> The deviation with a comment based on the SAF framework is also
>>>> mentioned as a last resort.
>>> 
>>> I don't see any reason to keep SAF-1 after this patch. So can this be 
>>> removed?
>>> 
>> 
>> In documenting-violations.rst it's stated:
>> "Entries in the database shall never be removed, even if they are not 
>> used
>> anymore in the code (if a patch is removing or modifying the faulty 
>> line).
>> This is to make sure that numbers are not reused which could lead to 
>> conflicts
>> with old branches or misleading justifications."
> 
> I read this as the number can not be re-used. But we could replace the 
> description with "Not used anymore".
> 
>> 
>> that's why I kept SAF-1 in the safe.json file and added the remark 
>> about it
>> being a last resort.
> 
> Right, but this is confusing. What is the last resort? Why would one 
> use it? It would be best to not mention SAF-1 at all in deviations.rst.
> 
> Cheers,

Ok, I'll submit a v2

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)