All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Wiles,
	Roger Keith"
	<keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool	pointer.
Date: Wed, 01 Oct 2014 15:36:45 +0200	[thread overview]
Message-ID: <8437457.lrG762lvxy@xps13> (raw)
In-Reply-To: <20140928122706.GB30445-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

2014-09-28 08:27, Neil Horman:
> On Sun, Sep 28, 2014 at 05:28:44AM +0000, Wiles, Roger Keith wrote:
> > Check the FILE *f and rte_mempool *mp pointers for NULL and
> > return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled.
> > 
> > Signed-off-by: Keith Wiles <keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
> 
> I'm fine with this, as I think passing in a NULL mempool is clearly a bug here,
> thats worth panicing over, though I wouldnt mind if we did a RTE_VERIFY_WARN
> macro here instead using what I suggested in my other note

Passing a NULL mempool to rte_mempool_dump() is a bug in the application.
If you look elsewhere in the DPDK code, you'll see that it's not common to do
such check on input parameters.
A similar discussion already happened few months ago:
	http://dpdk.org/ml/archives/dev/2014-June/003900.html

-- 
Thomas

  parent reply	other threads:[~2014-10-01 13:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 18:35 [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer Wiles, Roger Keith
     [not found] ` <DAE811FA-C1F1-444D-980C-311BCCE7FF3C-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-09-28  0:37   ` Neil Horman
     [not found]     ` <20140928003719.GA27849-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-09-28  1:10       ` Wiles, Roger Keith
2014-09-28  1:14       ` Wiles, Roger Keith
     [not found]         ` <A4B5A27D-D8B1-4391-907A-C6262A13FDC6-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-09-28  1:55           ` Neil Horman
     [not found]             ` <20140928015504.GA28263-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-09-28  5:38               ` Wiles, Roger Keith
     [not found]                 ` <831919DA-CEF0-4DA5-AF5D-5B1067F7A602-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-09-28 12:25                   ` Neil Horman
2014-09-28  5:28   ` [PATCH v2] " Wiles, Roger Keith
     [not found]     ` <05E7C1C5-2730-4BE3-B808-6F69821F7898-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-09-28 12:27       ` Neil Horman
     [not found]         ` <20140928122706.GB30445-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-09-28 14:37           ` Wiles, Roger Keith
2014-10-01 13:36           ` Thomas Monjalon [this message]
2014-10-01 15:02             ` Neil Horman
     [not found]               ` <20141001150227.GC24028-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-10-01 15:43                 ` Bruce Richardson
2014-10-01 15:57                   ` Wiles, Roger Keith
2014-10-01 16:01                   ` Neil Horman
     [not found]                     ` <20141001160109.GE24028-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-10-01 16:05                       ` Bruce Richardson
2014-10-02  7:47                         ` Thomas Monjalon
2014-10-02 11:37                           ` Neil Horman
     [not found]                             ` <20141002113720.GA4900-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-27 16:32                               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8437457.lrG762lvxy@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.