From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: devicetree@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Input: hideep - Optionally reset controller work mode to native HiDeep protocol
Date: Sat, 11 Mar 2023 12:36:16 +0100 [thread overview]
Message-ID: <843bb433-e8ae-41f2-7b5f-cc5ee289dbfd@kernel.org> (raw)
In-Reply-To: <4a273927-fa03-8503-e1c8-94b0223e80d1@redhat.com>
On 11/03/2023 12:16, Hans de Goede wrote:
>
> "hideep,force-native-protocol" is a good suggestion I'll prepare a new
> version with that.
>
>>> Anyways I just realized I should have not included this at all,
>>> since atm this new property is only used on X86/ACPI platforms
>>> (through platform code setting a device-property), so it is not
>>> used on devicetree platforms at all.
>>
>> Even if such properties are not documented I do not see how it will
>> prevent people from using them... I guess if they validate DT they will
>> be caught, but I am not sure that we can rely on this happening.
>
> Right, but I have beene explicitly told multiple times (1) to not document
> device-properties when they are only used between x86 platform code and
> drivers consuming them (and thus not actually used in any DT files
> at that point in time).
Comment in the code that this is not a DT property, is the most we can
do now (so people won't use it later as argument to add to the binding)...
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-11 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 22:21 [PATCH v2 0/2] Input: hideep - 2 HiDeep touchscreen patches Hans de Goede
2023-03-03 22:21 ` [PATCH v2 1/2] Input: hideep - Silence error in SW_RESET() Hans de Goede
2023-03-03 22:21 ` [PATCH v2 2/2] Input: hideep - Optionally reset controller work mode to native HiDeep protocol Hans de Goede
2023-03-05 13:34 ` Krzysztof Kozlowski
2023-03-05 15:04 ` Hans de Goede
2023-03-11 4:48 ` Dmitry Torokhov
2023-03-11 11:16 ` Hans de Goede
2023-03-11 11:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=843bb433-e8ae-41f2-7b5f-cc5ee289dbfd@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.