All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Saravana Kannan" <saravanak@google.com>
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] driver core: Avoid false-positive errors for intentionally skipped links
Date: Wed, 16 Oct 2024 12:19:46 +0100	[thread overview]
Message-ID: <843da504-34bb-4067-85b6-49851a1ff517@nvidia.com> (raw)
In-Reply-To: <20241015-fwdevlink-probed-no-err-v2-0-756c5e9cf55c@collabora.com>


On 15/10/2024 22:27, Nícolas F. R. A. Prado wrote:
> This series gets rid of the false-positive errors printed when device
> links are intentionally skipped. Patch 1 commonizes the logic into a
> helper and patch 2 uses that to remove the error.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> Changes in v2:
> - Added patch 1 introducing the device_link_is_useless() helper and used
>    that in patch 2
> - Link to v1: https://lore.kernel.org/r/20240624-fwdevlink-probed-no-err-v1-1-d1213cd354e2@collabora.com
> 
> ---
> Nícolas F. R. A. Prado (2):
>        driver core: Create device_link_is_useless() helper
>        driver core: Don't log intentional skip of device link creation as error
> 
>   drivers/base/core.c | 28 +++++++++++++++++++---------
>   1 file changed, 19 insertions(+), 9 deletions(-)


Looks good to me. For the series ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic

  parent reply	other threads:[~2024-10-16 11:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 21:27 [PATCH v2 0/2] driver core: Avoid false-positive errors for intentionally skipped links Nícolas F. R. A. Prado
2024-10-15 21:27 ` [PATCH v2 1/2] driver core: Create device_link_is_useless() helper Nícolas F. R. A. Prado
2024-10-15 21:27 ` [PATCH v2 2/2] driver core: Don't log intentional skip of device link creation as error Nícolas F. R. A. Prado
2024-10-16  5:37   ` Greg Kroah-Hartman
2024-10-16 11:19 ` Jon Hunter [this message]
2024-10-23 20:03 ` [PATCH v2 0/2] driver core: Avoid false-positive errors for intentionally skipped links Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=843da504-34bb-4067-85b6-49851a1ff517@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=rafael@kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.