From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn1qf-0003O4-KQ for qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:11:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn1qc-0006gi-G0 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:11:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59296) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dn1qc-0006gG-A3 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:11:54 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 543DCC0587E9 for ; Wed, 30 Aug 2017 12:11:52 +0000 (UTC) Date: Wed, 30 Aug 2017 08:11:51 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <844220409.5983155.1504095111596.JavaMail.zimbra@redhat.com> In-Reply-To: <87val5gta4.fsf@dusky.pond.sub.org> References: <20170825105913.4060-1-marcandre.lureau@redhat.com> <20170825105913.4060-5-marcandre.lureau@redhat.com> <87val5gta4.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Hi ----- Original Message ----- > Marc-Andr=C3=A9 Lureau writes: >=20 > > They are not considered constant expressions in C, producing an error > > when compiling a const QLit. >=20 > A const QLit? Do you mean a non-const one? Really a const QLitObject: const QLitObject qmp_schema_qlit =3D QLIT_QLIST(((QLitObject[]) { QLIT_QNULL, {} })); qmp-introspect.c:17:63: error: initializer element is not constant const QLitObject qmp_schema_qlit =3D QLIT_QLIST(((QLitObject[]) { ^ Removing the "compound literals" fixes this error. We may want to include it in the commit message, but I think it lacks a bit= of "C standard" explanation. I think it is something like "compound litera= ls" are not const. But then why does it work with (QLitObject[]) ? :) >=20 > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > --- > > include/qapi/qmp/qlit.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h > > index a4ad91321b..f1d6eed317 100644 > > --- a/include/qapi/qmp/qlit.h > > +++ b/include/qapi/qmp/qlit.h > > @@ -36,13 +36,13 @@ struct QLitDictEntry { > > }; > > =20 > > #define QLIT_QNUM(val) \ > > - (QLitObject){.type =3D QTYPE_QNUM, .value.qnum =3D (val)} > > + { .type =3D QTYPE_QNUM, .value.qnum =3D (val) } > > #define QLIT_QSTR(val) \ > > - (QLitObject){.type =3D QTYPE_QSTRING, .value.qstr =3D (val)} > > + { .type =3D QTYPE_QSTRING, .value.qstr =3D (val) } > > #define QLIT_QDICT(val) \ > > - (QLitObject){.type =3D QTYPE_QDICT, .value.qdict =3D (val)} > > + { .type =3D QTYPE_QDICT, .value.qdict =3D (val) } > > #define QLIT_QLIST(val) \ > > - (QLitObject){.type =3D QTYPE_QLIST, .value.qlist =3D (val)} > > + { .type =3D QTYPE_QLIST, .value.qlist =3D (val) } > > =20 > > int compare_litqobj_to_qobj(QLitObject *lhs, QObject *rhs); >=20