From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 03/16] of: dynamic: Add __of_node_dupv() Date: Wed, 21 Feb 2018 14:15:39 +0200 Message-ID: <8443535.FeXUiDPB9F@avalon> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-4-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: Marek Vasut , Laurent Pinchart , Wolfram Sang , Koen Kooi , Pantelis Antoniou , Linux Kernel Mailing List , DRI Development , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux I2C , Matt Porter , Frank Rowand , Guenter Roeck List-Id: linux-i2c@vger.kernel.org SGkgR2VlcnQsCgpPbiBXZWRuZXNkYXksIDIxIEZlYnJ1YXJ5IDIwMTggMTI6MjY6NDUgRUVUIEdl ZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToKPiBPbiBXZWQsIEZlYiAyMSwgMjAxOCBhdCAxMjoxMCBB TSwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IEZyb206IFBhbnRlbGlzIEFudG9uaW91IDxw YW50ZWxpcy5hbnRvbmlvdUBrb25zdWxrby5jb20+Cj4gPiAKPiA+IEFkZCBhbiBfX29mX25vZGVf ZHVwdigpIHByaXZhdGUgbWV0aG9kIGFuZCBtYWtlIF9fb2Zfbm9kZV9kdXAoKSB1c2UgaXQuCj4g PiBUaGlzIGlzIHJlcXVpcmVkIGZvciB0aGUgc3Vic2VxdWVudCBjaGFuZ2VzZXQgYWNjZXNzb3Jz IHdoaWNoIHdpbGwKPiA+IG1ha2UgdXNlIG9mIGl0Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBQ YW50ZWxpcyBBbnRvbmlvdSA8cGFudGVsaXMuYW50b25pb3VAa29uc3Vsa28uY29tPgo+ID4gU2ln bmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydAo+ID4gPGxhdXJlbnQucGluY2hhcnQrcmVuZXNh c0BpZGVhc29uYm9hcmQuY29tPgo+ID4gLS0tCj4gPiAKPiA+ICBkcml2ZXJzL29mL2R5bmFtaWMu YyB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDIzIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL29mL2R5bmFtaWMuYyBiL2RyaXZlcnMvb2YvZHluYW1pYy5jCj4gPiBpbmRleCA3YmIz M2QyMmI0ZTIuLjRmZmQwNDkyNWZkZiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvb2YvZHluYW1p Yy5jCj4gPiArKysgYi9kcml2ZXJzL29mL2R5bmFtaWMuYwo+ID4gQEAgLTM4Miw4ICszODIsOSBA QCBzdHJ1Y3QgcHJvcGVydHkgKl9fb2ZfcHJvcF9kdXAoY29uc3Qgc3RydWN0IHByb3BlcnR5Cj4g PiAqcHJvcCwgZ2ZwX3QgYWxsb2NmbGFncyk+IAo+ID4gIH0KPiA+ICAKPiA+ICAvKioKPiA+IAo+ ID4gLSAqIF9fb2Zfbm9kZV9kdXAoKSAtIER1cGxpY2F0ZSBvciBjcmVhdGUgYW4gZW1wdHkgZGV2 aWNlIG5vZGUKPiA+IGR5bmFtaWNhbGx5Lgo+ID4gLSAqIEBmbXQ6IEZvcm1hdCBzdHJpbmcgKHBs dXMgdmFyZ3MpIGZvciBuZXcgZnVsbCBuYW1lIG9mIHRoZSBkZXZpY2Ugbm9kZQo+ID4gKyAqIF9f b2Zfbm9kZV9kdXB2KCkgLSBEdXBsaWNhdGUgb3IgY3JlYXRlIGFuIGVtcHR5IGRldmljZSBub2Rl Cj4gPiBkeW5hbWljYWxseS4gKyAqIEBmbXQ6IEZvcm1hdCBzdHJpbmcgZm9yIG5ldyBmdWxsIG5h bWUgb2YgdGhlIGRldmljZSBub2RlCj4gPiArICogQHZhcmdzOiB2YV9saXN0IGNvbnRhaW5pbmcg dGhlIGFydWdtZW50cyBmb3IgdGhlIG5vZGUgZnVsbCBuYW1lCj4gPiAKPiA+ICAgKgo+ID4gICAq IENyZWF0ZSBhbiBkZXZpY2UgdHJlZSBub2RlLCBlaXRoZXIgYnkgZHVwbGljYXRpbmcgYW4gZW1w dHkgbm9kZSBvciBieQo+ID4gICBhbGxvY2F0aW5nICogYW4gZW1wdHkgb25lIHN1aXRhYmxlIGZv ciBmdXJ0aGVyIG1vZGlmaWNhdGlvbi4gIFRoZSBub2RlCj4gPiAgIGRhdGEgYXJlPiAKPiA+IEBA IC0zOTEsMTcgKzM5MiwxNSBAQCBzdHJ1Y3QgcHJvcGVydHkgKl9fb2ZfcHJvcF9kdXAoY29uc3Qg c3RydWN0IHByb3BlcnR5Cj4gPiAqcHJvcCwgZ2ZwX3QgYWxsb2NmbGFncyk+IAo+ID4gICAqIE9G X0RFVEFDSEVEIGJpdHMgc2V0LiBSZXR1cm5zIHRoZSBuZXdseSBhbGxvY2F0ZWQgbm9kZSBvciBO VUxMIG9uIG91dAo+ID4gICBvZgo+ID4gICAqIG1lbW9yeSBlcnJvci4KPiA+ICAgKi8KPiA+IAo+ ID4gLXN0cnVjdCBkZXZpY2Vfbm9kZSAqX19vZl9ub2RlX2R1cChjb25zdCBzdHJ1Y3QgZGV2aWNl X25vZGUgKm5wLCBjb25zdAo+ID4gY2hhciAqZm10LCAuLi4pICtzdHJ1Y3QgZGV2aWNlX25vZGUg Kl9fb2Zfbm9kZV9kdXB2KGNvbnN0IHN0cnVjdAo+ID4gZGV2aWNlX25vZGUgKm5wLAo+IAo+IHN0 YXRpYywgY2ZyLgo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwv Z2l0L2dlZXJ0L3JlbmVzYXMtZHJpdmVycy5naXQvY28KPiBtbWl0Lz9oPXRvcGljL292ZXJsYXlz JmlkPWM0NTMyNGUxODA3ZGQ3MDgzNDRjOWE0NzhiNzc3YjY4YWNhMTFjZGYKCkknbGwgZml4IHRo YXQgaW4gdGhlIG5leHQgdmVyc2lvbi4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:47267 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbeBUMO6 (ORCPT ); Wed, 21 Feb 2018 07:14:58 -0500 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , DRI Development , Linux-Renesas , Pantelis Antoniou , Rob Herring , Frank Rowand , Matt Porter , Koen Kooi , Guenter Roeck , Marek Vasut , Wolfram Sang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C Subject: Re: [PATCH v4 03/16] of: dynamic: Add __of_node_dupv() Date: Wed, 21 Feb 2018 14:15:39 +0200 Message-ID: <8443535.FeXUiDPB9F@avalon> In-Reply-To: References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-4-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Wednesday, 21 February 2018 12:26:45 EET Geert Uytterhoeven wrote: > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > Add an __of_node_dupv() private method and make __of_node_dup() use it. > > This is required for the subsequent changeset accessors which will > > make use of it. > > > > Signed-off-by: Pantelis Antoniou > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/of/dynamic.c | 29 +++++++++++++++++++++++------ > > 1 file changed, 23 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > > index 7bb33d22b4e2..4ffd04925fdf 100644 > > --- a/drivers/of/dynamic.c > > +++ b/drivers/of/dynamic.c > > @@ -382,8 +382,9 @@ struct property *__of_prop_dup(const struct property > > *prop, gfp_t allocflags)> > > } > > > > /** > > > > - * __of_node_dup() - Duplicate or create an empty device node > > dynamically. > > - * @fmt: Format string (plus vargs) for new full name of the device node > > + * __of_node_dupv() - Duplicate or create an empty device node > > dynamically. + * @fmt: Format string for new full name of the device node > > + * @vargs: va_list containing the arugments for the node full name > > > > * > > * Create an device tree node, either by duplicating an empty node or by > > allocating * an empty one suitable for further modification. The node > > data are> > > @@ -391,17 +392,15 @@ struct property *__of_prop_dup(const struct property > > *prop, gfp_t allocflags)> > > * OF_DETACHED bits set. Returns the newly allocated node or NULL on out > > of > > * memory error. > > */ > > > > -struct device_node *__of_node_dup(const struct device_node *np, const > > char *fmt, ...) +struct device_node *__of_node_dupv(const struct > > device_node *np, > > static, cfr. > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/co > mmit/?h=topic/overlays&id=c45324e1807dd708344c9a478b777b68aca11cdf I'll fix that in the next version. -- Regards, Laurent Pinchart