diff for duplicates of <8447746.miDbEHA5rR@diego> diff --git a/a/1.txt b/N1/1.txt index ad3bc43..a18926d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,37 +1,34 @@ Hi Shawn, -Am Sonntag, 13. M=E4rz 2016, 00:25:25 schrieb Shawn Lin: +Am Sonntag, 13. März 2016, 00:25:25 schrieb Shawn Lin: > We should call iounmap to relase reg_base since it's not going > to be used any more. ->=20 +> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> I see that change for rk3036, rk3188(+rk3066) and rk3368. -But it looks like rk3228 and rk3288 should also get that, or am I just=20= - +But it looks like rk3228 and rk3288 should also get that, or am I just overlooking something? -Also, I think we can fold these changes into one patch, as it's the com= -pletely=20 +Also, I think we can fold these changes into one patch, as it's the completely same addition for all clock-drivers. Heiko > --- ->=20 +> > drivers/clk/rockchip/clk-rk3036.c | 1 + > 1 file changed, 1 insertion(+) ->=20 +> > diff --git a/drivers/clk/rockchip/clk-rk3036.c > b/drivers/clk/rockchip/clk-rk3036.c index 8c683cc..284c36f 100644 > --- a/drivers/clk/rockchip/clk-rk3036.c > +++ b/drivers/clk/rockchip/clk-rk3036.c -> @@ -453,6 +453,7 @@ static void __init rk3036_clk_init(struct device_= -node -> *np) ctx =3D rockchip_clk_init(np, reg_base, CLK_NR_CLKS); -> =09if (IS_ERR(ctx)) { -> =09=09pr_err("%s: rockchip clk init failed\n", __func__); -> +=09=09iounmap(reg_base); -> =09=09return; -> =09} +> @@ -453,6 +453,7 @@ static void __init rk3036_clk_init(struct device_node +> *np) ctx = rockchip_clk_init(np, reg_base, CLK_NR_CLKS); +> if (IS_ERR(ctx)) { +> pr_err("%s: rockchip clk init failed\n", __func__); +> + iounmap(reg_base); +> return; +> } diff --git a/a/content_digest b/N1/content_digest index 38bb9a6..0190760 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,40 +14,37 @@ "b\0" "Hi Shawn,\n" "\n" - "Am Sonntag, 13. M=E4rz 2016, 00:25:25 schrieb Shawn Lin:\n" + "Am Sonntag, 13. M\303\244rz 2016, 00:25:25 schrieb Shawn Lin:\n" "> We should call iounmap to relase reg_base since it's not going\n" "> to be used any more.\n" - ">=20\n" + "> \n" "> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>\n" "\n" "I see that change for rk3036, rk3188(+rk3066) and rk3368.\n" - "But it looks like rk3228 and rk3288 should also get that, or am I just=20=\n" - "\n" + "But it looks like rk3228 and rk3288 should also get that, or am I just \n" "overlooking something?\n" "\n" - "Also, I think we can fold these changes into one patch, as it's the com=\n" - "pletely=20\n" + "Also, I think we can fold these changes into one patch, as it's the completely \n" "same addition for all clock-drivers.\n" "\n" "\n" "Heiko\n" "\n" "> ---\n" - ">=20\n" + "> \n" "> drivers/clk/rockchip/clk-rk3036.c | 1 +\n" "> 1 file changed, 1 insertion(+)\n" - ">=20\n" + "> \n" "> diff --git a/drivers/clk/rockchip/clk-rk3036.c\n" "> b/drivers/clk/rockchip/clk-rk3036.c index 8c683cc..284c36f 100644\n" "> --- a/drivers/clk/rockchip/clk-rk3036.c\n" "> +++ b/drivers/clk/rockchip/clk-rk3036.c\n" - "> @@ -453,6 +453,7 @@ static void __init rk3036_clk_init(struct device_=\n" - "node\n" - "> *np) ctx =3D rockchip_clk_init(np, reg_base, CLK_NR_CLKS);\n" - "> =09if (IS_ERR(ctx)) {\n" - "> =09=09pr_err(\"%s: rockchip clk init failed\\n\", __func__);\n" - "> +=09=09iounmap(reg_base);\n" - "> =09=09return;\n" - > =09} + "> @@ -453,6 +453,7 @@ static void __init rk3036_clk_init(struct device_node\n" + "> *np) ctx = rockchip_clk_init(np, reg_base, CLK_NR_CLKS);\n" + "> \tif (IS_ERR(ctx)) {\n" + "> \t\tpr_err(\"%s: rockchip clk init failed\\n\", __func__);\n" + "> +\t\tiounmap(reg_base);\n" + "> \t\treturn;\n" + "> \t}" -0ba7bda4330143ac9e34e886145aa795c059a9dac2414b7a869831ba3c86bc91 +5dc8b9e684ea15bc9e85eb13ab1de8ccaf573256f1558264cb63beabbe40266d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.