From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63D4BEB64DA for ; Thu, 20 Jul 2023 06:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gYF4qziCb9HWvqVMD6enbEBbADNXzzcg+GPXKqIveK8=; b=jpTx00OhIKvcaF S5QZla2OAsppuN0xPpH/KLql4FBX/M6sElqPn5zQfpWQItxLImZobJmjKFqC57ax0IccUofNxOit4 pxYd7Nk6r1JibI3elmbWaId+OVEOfsy6mfbqOeMNg5ruQfo6pBiFHQBNU5sbhq1C/hCMA/TCdGSo7 5rzQQMPRIR5RBUXBxXqzOkaTrrA7c9uahjXr+fwuNmBAL3Vc3eO/86JjBa3uRu1py8SBIZhzwGaKZ gtJ93jwO+oose1g3LRwwInDao1VSUZ2TMwjxz5XAM1qOyo8q7DvT8Unn8kxfhZcOr6Uf2vjVRsFMq kH8EqFlQeF33yap67yJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMNTH-009zrs-1P; Thu, 20 Jul 2023 06:49:07 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMNTD-009zqJ-2c for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 06:49:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1689835743; x=1721371743; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WZ3v3utVO0Zb95j6GDnt+exK2K/OuKT5kKWXUw3dTW4=; b=Snu014I9WKc3AQCPVP91l56WP81PJE1Byn2nLbS49WjjrEDQdHhAbBP+ WHkeUOEuIMyTge2A3woNiANx3i/nBtFovZqN26nzZndDwnEGhR2A1xJrY P0Ux2ETv/pBnkodNb+19WgON+1/HAgwWlt1t92VllVHRiDd/rZVQVAjSE t1KX4cZMQRCD2aToH2BmQOr7W6Gc0MUVQx6KGi5HF7Ktc511GHrkzHRSw Nzxw2AHFoQtk+l7a382UzvEklqO6mfIo1mR/HPseNL5Awbtd6K8GV7DYY gb4xMjarJe2VYoPS5BV9KWsaTm4N5G2flNVe6yYnNVPRPr/vq56Ttmgji w==; X-IronPort-AV: E=Sophos;i="6.01,218,1684792800"; d="scan'208";a="32023041" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 20 Jul 2023 08:49:01 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 57989280078; Thu, 20 Jul 2023 08:49:01 +0200 (CEST) From: Alexander Stein To: Tim Harvey Cc: Pengutronix Kernel Team , NXP Linux Team , linux-media , Linux ARM Mailing List , Fabio Estevam , Sascha Hauer , Mauro Carvalho Chehab , Rui Miguel Silva , Shawn Guo , Laurent Pinchart , Schrempf Frieder Subject: Re: media: imx: imx7-media-csi: Get rid of superfluous call to imx7_csi_mbus_fm t_to_pix_fmt Date: Thu, 20 Jul 2023 08:49:00 +0200 Message-ID: <844922189.0ifERbkFSE@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <2290635.ElGaqSPkdT@steina-w> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_234904_239743_AED05846 X-CRM114-Status: GOOD ( 36.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVGltLAoKQW0gTWl0dHdvY2gsIDE5LiBKdWxpIDIwMjMsIDE5OjI3OjU0IENFU1Qgc2Nocmll YiBUaW0gSGFydmV5Ogo+IE9uIE1vbiwgSnVsIDE3LCAyMDIzIGF0IDI6NTfigK9BTSBBbGV4YW5k ZXIgU3RlaW4KPiAKPiA8YWxleGFuZGVyLnN0ZWluQGV3LnRxLWdyb3VwLmNvbT4gd3JvdGU6Cj4g PiBIaSBUaW0sCj4gPiAKPiA+IEFtIEZyZWl0YWcsIDE0LiBKdWxpIDIwMjMsIDAzOjM0OjE1IENF U1Qgc2NocmllYiBUaW0gSGFydmV5Ogo+ID4gPiBBbGV4YW5kZXIsCj4gPiA+IAo+ID4gPiBJIGZv dW5kIHRoYXQgY29tbWl0IDZmNDgyYzQ3MjlkOTogKCJtZWRpYTogaW14OiBpbXg3LW1lZGlhLWNz aTogR2V0Cj4gPiA+IHJpZCBvZiBzdXBlcmZsdW91cyBjYWxsIHRvIGlteDdfY3NpX21idXNfZm10 X3RvX3BpeF9mbXQiKSBpbnRyb2R1Y2VkCj4gPiA+IGFuIGlzc3VlIGNhdXNpbmcgbWUgdG8gbm90 IGJlIGFibGUgdG8gY2FwdHVyZSBhbnltb3JlIG9uIGFuIGlteDhtbQo+ID4gPiB3aXRoIGFuIGlt eDIxOSBjYW1lcmEuCj4gPiA+IAo+ID4gPiBJJ20gdXNpbmcgYSBSYXNwYmVycnlQaSBDYW1lcmEg djIgd2hpY2ggaGFzIGFuIElNWDIxOSA4TVAgY2FtZXJhIG1vZHVsZToKPiA+ID4gLSBodHRwczov L2RhdGFzaGVldHMucmFzcGJlcnJ5cGkuY29tL2NhbWVyYS9jYW1lcmEtdjItc2NoZW1hdGljcy5w ZGYKPiA+ID4gLSBoYXMgaXRzIG93biBvbi1ib2FyZCAyNE1IeiBvc2Mgc28gbm8gY2xvY2sgcmVx dWlyZWQgZnJvbSBiYXNlYm9hcmQKPiA+ID4gLSBwaW4gMTEgZW5hYmxlcyAxLjhWIGFuZCAyLjhW IExETyB3aGljaCBpcyBjb25uZWN0ZWQgdG8gYSBHUElPIEkgdXNlCj4gPiA+IGFzIGEgcmVndWxh dG9yIGVuYWJsZQo+ID4gPiAKPiA+ID4gSSdtIHVzaW5nIHRoZSBpbXg4bW0tdmVuaWNlLWd3NzJ4 eC0weC1pbXgyMTkgZHQgb3ZlcmxheSBbMV0gdG8gdGVzdAo+ID4gPiB0aGlzLgo+ID4gPiAKPiA+ ID4gSGVyZSBpcyBzb21lIGFkZGl0aW9uYWwgaW5mb3JtYXRpb24gYWJvdXQgaG93IEknbSB1c2lu ZyB0aGUgY2FtZXJhCj4gPiA+IG1vZHVsZToKPiA+ID4gIyBjYXQgL3N5cy9idXMvbWVkaWEvZGV2 aWNlcy9tZWRpYSovbW9kZWwKPiA+ID4gaW14LW1lZGlhCj4gPiA+IGhhbnRyby12cHUKPiA+ID4g aGFudHJvLXZwdQo+ID4gPiAjIGNhdCAvc3lzL2NsYXNzL3ZpZGVvNGxpbnV4L3ZpZGVvKi9uYW1l Cj4gPiA+IGNzaSBjYXB0dXJlCj4gPiA+IG54cCxpbXg4bW0tdnB1LWcxLWRlYwo+ID4gPiBueHAs aW14OG1xLXZwdS1nMi1kZWMKPiA+ID4gIyBlbmFibGUgaW14MjE5IHRvIGNzaSBsaW5rCj4gPiA+ IG1lZGlhLWN0bCAtLXJlc2V0Cj4gPiA+IG1lZGlhLWN0bCAtbCAiJ2lteDIxOSAyLTAwMTAnOjAg LT4gJ2NzaXMtMzJlMzAwMDAubWlwaS1jc2knOjAgWzFdIgo+ID4gPiAjIGNvbmZpZ3VyZSBmb3Ig NjQweDQ4MCByYXc4Cj4gPiA+IG1lZGlhLWN0bCAtdiAtViAiJ2lteDIxOSAyLTAwMTAnOjAgW2Zt dDpTUkdHQjgvNjQweDQ4MCBmaWVsZDpub25lXSIKPiA+ID4gbWVkaWEtY3RsIC12IC1WICInY3Np cy0zMmUzMDAwMC5taXBpLWNzaSc6MCBbZm10OlNSR0dCOC82NDB4NDgwCj4gPiA+IGZpZWxkOm5v bmVdIiBtZWRpYS1jdGwgLXYgLVYgIidjc2knOjAgW2ZtdDpTUkdHQjgvNjQweDQ4MCBmaWVsZDpu b25lXSIKPiA+ID4gIyBjb25maWd1cmUgZm9yIFJHR0IgKDgtYml0IGJheWVyKSwgNjQweDQ4MCBy ZXNvbHV0aW9uCj4gPiA+IHY0bDItY3RsIC0tZGV2aWNlIC9kZXYvdmlkZW8wCj4gPiA+IC0tc2V0 LWZtdC12aWRlbz13aWR0aD02NDAsaGVpZ2h0PTQ4MCxwaXhlbGZvcm1hdD1SR0dCIC0tdmVyYm9z ZQo+ID4gPiAKPiA+ID4gYmVmb3JlIGNvbW1pdCA2ZjQ4MmM0NzI5ZDk6ICgibWVkaWE6IGlteDog aW14Ny1tZWRpYS1jc2k6IEdldCByaWQgb2YKPiA+ID4gc3VwZXJmbHVvdXMgY2FsbCB0byBpbXg3 X2NzaV9tYnVzX2ZtdF90b19waXhfZm10IikgdGhpcyB3b3VsZCByZXBvcnQKPiA+ID4gYmFjayA2 NDB4NDgwIHJlc29sdXRpb246Cj4gPiA+IFZJRElPQ19RVUVSWUNBUDogb2sKPiA+ID4gVklESU9D X0dfRk1UOiBvawo+ID4gPiBWSURJT0NfU19GTVQ6IG9rCj4gPiA+IAo+ID4gPiBGb3JtYXQgVmlk ZW8gQ2FwdHVyZToKPiA+ID4gICAgICAgICBXaWR0aC9IZWlnaHQgICAgICA6IDY0MC80ODAKPiA+ ID4gICAgICAgICBQaXhlbCBGb3JtYXQgICAgICA6ICdSR0dCJyAoOC1iaXQgQmF5ZXIgUkdSRy9H QkdCKQo+ID4gPiAgICAgICAgIEZpZWxkICAgICAgICAgICAgIDogTm9uZQo+ID4gPiAgICAgICAg IEJ5dGVzIHBlciBMaW5lICAgIDogNjQwCj4gPiA+ICAgICAgICAgU2l6ZSBJbWFnZSAgICAgICAg OiAzMDcyMDAKPiA+ID4gICAgICAgICBDb2xvcnNwYWNlICAgICAgICA6IERlZmF1bHQKPiA+ID4g ICAgICAgICBUcmFuc2ZlciBGdW5jdGlvbiA6IERlZmF1bHQgKG1hcHMgdG8gUmVjLiA3MDkpCj4g PiA+ICAgICAgICAgWUNiQ3IvSFNWIEVuY29kaW5nOiBEZWZhdWx0IChtYXBzIHRvIElUVS1SIDYw MSkKPiA+ID4gICAgICAgICBRdWFudGl6YXRpb24gICAgICA6IERlZmF1bHQgKG1hcHMgdG8gRnVs bCBSYW5nZSkKPiA+ID4gCj4gPiA+ICAgICAgICAgRmxhZ3MgICAgICAgICAgICAgOgo+ID4gPiBB bmQgYWZ0ZXIgdGhlIGNvbW1pdCBpdCByZXBvcnRzIGJhY2sgYW4gaW52YWxpZCA3Njh4NDgwIHJl c29sdXRpb246Cj4gPiA+IFZJRElPQ19RVUVSWUNBUDogb2sKPiA+ID4gVklESU9DX0dfRk1UOiBv awo+ID4gPiBWSURJT0NfU19GTVQ6IG9rCj4gPiA+IAo+ID4gPiBGb3JtYXQgVmlkZW8gQ2FwdHVy ZToKPiA+ID4gICAgICAgICBXaWR0aC9IZWlnaHQgICAgICA6IDc2OC80ODAKPiA+ID4gICAgICAg ICBQaXhlbCBGb3JtYXQgICAgICA6ICdSR0dCJyAoOC1iaXQgQmF5ZXIgUkdSRy9HQkdCKQo+ID4g PiAgICAgICAgIEZpZWxkICAgICAgICAgICAgIDogTm9uZQo+ID4gPiAgICAgICAgIEJ5dGVzIHBl ciBMaW5lICAgIDogNzY4Cj4gPiA+ICAgICAgICAgU2l6ZSBJbWFnZSAgICAgICAgOiAzNjg2NDAK PiA+ID4gICAgICAgICBDb2xvcnNwYWNlICAgICAgICA6IERlZmF1bHQKPiA+ID4gICAgICAgICBU cmFuc2ZlciBGdW5jdGlvbiA6IERlZmF1bHQgKG1hcHMgdG8gUmVjLiA3MDkpCj4gPiA+ICAgICAg ICAgWUNiQ3IvSFNWIEVuY29kaW5nOiBEZWZhdWx0IChtYXBzIHRvIElUVS1SIDYwMSkKPiA+ID4g ICAgICAgICBRdWFudGl6YXRpb24gICAgICA6IERlZmF1bHQgKG1hcHMgdG8gRnVsbCBSYW5nZSkK PiA+ID4gCj4gPiA+ICAgICAgICAgRmxhZ3MgICAgICAgICAgICAgOgo+ID4gPiBUaGlzIHJlc29s dXRpb24gYW5kIGZyYW1lIHNpemUgbWlzLW1hdGNoIGNhdXNlcyBpc3N1ZXMgZm9yIGV4YW1wbGUK PiA+ID4gd2hlbiB1c2luZyBnc3RyZWFtZXIgdG8gY2FwdHVyZSBhbmQgc3RyZWFtIGZyYW1lcy4K PiA+IAo+ID4gT2gsIHRoYXQncyB3ZWlyZC4gQ2FuIHlvdSBjaGVjayB3aGF0IHRoZSBjYWxsIHRv IHY0bF9ib3VuZF9hbGlnbl9pbWFnZSgpCj4gPiBpbnNpZGUgX19pbXg3X2NzaV92aWRlb190cnlf Zm10KCkgaXMgYWN0dWFsbHkgZG9pbmc/IENoZWNrIHdhbGlnbiwgd2lkdGgKPiA+IGJlZm9yZSBh bmQgYWZ0ZXIgdGhlIGNhbGwuIEZyb20gYSBnbGFuY2UgdGhhdCBzZWVtcyB0byBiZSB0aGUgb25s eSB3YXkKPiA+IHdpZHRoIGNvdWxkIGJlIG1vZGlmaWVkLgo+IAo+IHdpdGggZGVidWdnaW5nIGFk ZGVkIGluIF9faW14N19jc2lfdmlkZW9fdHJ5X2ZtdDoKPiAKPiByb290QGphbW15LXZlbmljZTp+ IyBkbWVzZyB8IGdyZXAgY3NpCj4gWyAgICAwLjAzODQ5NV0gcGxhdGZvcm0gMzJlMzAwMDAubWlw aS1jc2k6IEZpeGVkIGRlcGVuZGVuY3kgY3ljbGUocykKPiB3aXRoIC9zb2NAMC9idXNAMzJjMDAw MDAvY3NpQDMyZTIwMDAwL3BvcnQvZW5kcG9pbnQKPiBbICAgIDEuMTk1MDU1XSBfX2lteDdfY3Np X3ZpZGVvX3RyeV9mbXQgd2FsaWduPTQgYnBwPTE2IDY0MC80ODAKPiBbICAgIDEuMjAwNzQ2XSBf X2lteDdfY3NpX3ZpZGVvX3RyeV9mbXQgd2FsaWduPTQgYnBwPTE2Cj4gYnl0ZXNwZXJsaW5lPTEy ODAgc2l6ZWltYWdlPTYxNDQwMCA2NDAvNDgwCj4gWyAgICAxLjIwOTYzM10gaW14Ny1jc2kgMzJl MjAwMDAuY3NpOiBSZWdpc3RlcmVkIGNzaSBjYXB0dXJlIGFzIC9kZXYvdmlkZW8wCj4gWyAgICAx Ljc3NTMyMV0gaTJjIDItMDAxMDogRml4ZWQgZGVwZW5kZW5jeSBjeWNsZShzKSB3aXRoCj4gL3Nv Y0AwL2J1c0AzMmMwMDAwMC9taXBpLWNzaUAzMmUzMDAwMC9wb3J0cy9wb3J0QDAvZW5kcG9pbnQK PiBbICAgIDIuMDEwMzcyXSBpbXgtbWlwaS1jc2lzIDMyZTMwMDAwLm1pcGktY3NpOiBsYW5lczog MiwgZnJlcTogMzMzMDAwMDAwCj4gXl5eIHRoaXMgaXMga2VybmVsIGluaXQgYW5kIGxvb2tzIGZp bmUKPiAKPiAjIG1lZGlhLWN0bCAtbCAiJ2lteDIxOSAyLTAwMTAnOjAgLT4gJ2NzaXMtMzJlMzAw MDAubWlwaS1jc2knOjAgWzFdIgo+ICMgbWVkaWEtY3RsIC12IC1WICInaW14MjE5IDItMDAxMCc6 MCBbZm10OlNSR0dCOC82NDB4NDgwIGZpZWxkOm5vbmVdIgo+ICMgbWVkaWEtY3RsIC12IC1WICIn Y3Npcy0zMmUzMDAwMC5taXBpLWNzaSc6MCBbZm10OlNSR0dCOC82NDB4NDgwCj4gZmllbGQ6bm9u ZV0iICMgbWVkaWEtY3RsIC12IC1WICInY3NpJzowIFtmbXQ6U1JHR0I4LzY0MHg0ODAgZmllbGQ6 bm9uZV0iCj4gXl5eIG5vdGhpbmcgY2hhbmdlcyBoZXJlIGR1cmluZyBsaW5rIGNvbmZpZyAobm8g Y2FsbHMgdG8KPiBfX2lteDdfY3NpX3ZpZGVvX3RyeV9mbXQpCj4gCj4gIyB2NGwyLWN0bCAtLWRl dmljZSAvZGV2L3ZpZGVvMAo+IC0tc2V0LWZtdC12aWRlbz13aWR0aD02NDAsaGVpZ2h0PTQ4MCxw aXhlbGZvcm1hdD1SR0dCIC0tdmVyYm9zZQo+IFZJRElPQ19RVUVSWUNBUDogb2sKPiBbICAxMjAu MzY3ODc0XSBfX2lteDdfY3NpX3ZpZGVvX3RyeV9mbXQgd2FsaWduPTggYnBwPTggNjQwLzQ4MAo+ IF5eXiBiZWZvcmUgY2FsbGluZyB2NGxfYm91bmRfYWxpZ25faW1hZ2UoKQo+IAo+IFZJRElPQ19H X0ZNVDogb2sKPiBbICAxMjAuMzc0OTc0XSBfX2lteDdfY3NpX3ZpZGVvX3RyeV9mbXQgd2FsaWdu PTggYnBwPTgKPiBieXRlc3BlcmxpbmU9NzY4IHNpemVpbWFnZT0zNjg2NDAgNzY4LzQ4MAo+IF5e XiBhZnRlciBjYWxsaW5nIHY0bF9ib3VuZF9hbGlnbl9pbWFnZSgpIHdpZHRoIGlzIGNoYW5nZWQg ZnJvbSA2NDAgdG8gNzY4CgpTbyB0aGlzIGNhbGwgaXMgdGhlIGN1bHByaXQsIEkgbm90aWNlZCB0 aGUgaW1wb3J0YW50IGNoYW5nZSB0byBiZWZvcmUuIFRoZSAKYWxpZ25tZW50IGVuZm9yY2VkIGlu IGNsYW1wX2FsaWduKCksIGNhbGxlZCBieSB2NGxfYm91bmRfYWxpZ25faW1hZ2UoKSwgaXMgYSAK bXVsdGlwbGUgb2YgMl5hbGlnbiwgX25vdF8gYSBtdWx0aXBsZSBvZiBhbGlnbi4gU28gb2J2aW91 c2x5IDY0MCBpcyBpbmNyZWFzZWQgCnRvIHRoZSBuZXh0IG11bHRpcGxlIG9mIDJeOCAoMjU2KSB3 aGljaCBpcyA3NjguIENhbiB5b3UgZ2l2ZSB0aGUgZm9sbG93aW5nIApkaWZmIGEgdHJ5PwoKLS04 PC0tCmRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL254cC9pbXg3LW1lZGlhLWNz aS5jIGIvZHJpdmVycy9tZWRpYS8KcGxhdGZvcm0vbnhwL2lteDctbWVkaWEtY3NpLmMKaW5kZXgg MmY5MzAyZmM3NTcwLi5hMDQwNjY1ZWNhN2MgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbWVkaWEvcGxh dGZvcm0vbnhwL2lteDctbWVkaWEtY3NpLmMKKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9u eHAvaW14Ny1tZWRpYS1jc2kuYwpAQCAtMTEzNyw5ICsxMTM3LDggQEAgX19pbXg3X2NzaV92aWRl b190cnlfZm10KHN0cnVjdCB2NGwyX3BpeF9mb3JtYXQgKnBpeGZtdCwKICAgICAgICAgKiBUT0RP OiBJbXBsZW1lbnQgY29uZmlndXJhYmxlIHN0cmlkZSBzdXBwb3J0LgogICAgICAgICAqLwogICAg ICAgIHdhbGlnbiA9IDggKiA4IC8gY2MtPmJwcDsKLSAgICAgICB2NGxfYm91bmRfYWxpZ25faW1h Z2UoJnBpeGZtdC0+d2lkdGgsIDEsIDB4ZmZmZiwgd2FsaWduLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAmcGl4Zm10LT5oZWlnaHQsIDEsIDB4ZmZmZiwgMSwgMCk7Ci0KKyAgICAgICBw aXhmbXQtPndpZHRoID0gY2xhbXBfcm91bmR1cChwaXhmbXQtPndpZHRoLCAxLCAweGZmZmYsIHdh bGlnbik7CisgICAgICAgcGl4Zm10LT5oZWlnaHQgPSBjbGFtcF9yb3VuZHVwKHBpeGZtdC0+d2lk dGgsIDEsIDB4ZmZmZiwgMSk7CiAgICAgICAgcGl4Zm10LT5ieXRlc3BlcmxpbmUgPSBwaXhmbXQt PndpZHRoICogY2MtPmJwcCAvIDg7CiAgICAgICAgcGl4Zm10LT5zaXplaW1hZ2UgPSBwaXhmbXQt PmJ5dGVzcGVybGluZSAqIHBpeGZtdC0+aGVpZ2h0OwogICAgICAgIHBpeGZtdC0+ZmllbGQgPSBW NEwyX0ZJRUxEX05PTkU7Ci0tODwtLQoKVGhhbmtzIGFuZCBiZXN0IHJlZ2FyZHMsCkFsZXhhbmRl cgoKPiBWSURJT0NfU19GTVQ6IG9rCj4gRm9ybWF0IFZpZGVvIENhcHR1cmU6Cj4gICAgICAgICBX aWR0aC9IZWlnaHQgICAgICA6IDc2OC80ODAKPiAgICAgICAgIFBpeGVsIEZvcm1hdCAgICAgIDog J1JHR0InICg4LWJpdCBCYXllciBSR1JHL0dCR0IpCj4gICAgICAgICBGaWVsZCAgICAgICAgICAg ICA6IE5vbmUKPiAgICAgICAgIEJ5dGVzIHBlciBMaW5lICAgIDogNzY4Cj4gICAgICAgICBTaXpl IEltYWdlICAgICAgICA6IDM2ODY0MAo+ICAgICAgICAgQ29sb3JzcGFjZSAgICAgICAgOiBEZWZh dWx0Cj4gICAgICAgICBUcmFuc2ZlciBGdW5jdGlvbiA6IERlZmF1bHQgKG1hcHMgdG8gUmVjLiA3 MDkpCj4gICAgICAgICBZQ2JDci9IU1YgRW5jb2Rpbmc6IERlZmF1bHQgKG1hcHMgdG8gSVRVLVIg NjAxKQo+ICAgICAgICAgUXVhbnRpemF0aW9uICAgICAgOiBEZWZhdWx0IChtYXBzIHRvIEZ1bGwg UmFuZ2UpCj4gCj4gICAgICAgICBGbGFncyAgICAgICAgICAgICA6Cj4gPiA+IEkgbm90aWNlZCB5 b3UgaGF2ZSBzZXZlcmFsIG91dHN0YW5kaW5nIHBhdGNoZXMgcGVuZGluZyBmb3IKPiA+ID4gaW14 Ny1tZWRpYS1jc2kuLi4gcGVyaGFwcyB0aGVyZSBpcyBzb21ldGhpbmcgdGhlcmUgeW91IGFscmVh ZHkga25vdyBvZgo+ID4gPiB0aGF0IGFkZHJlc3NlcyB0aGlzIGlzc3VlPwo+ID4gCj4gPiBUaGVy ZSBub3RoaW5nIHBlbmRpbmcgQUZBSUNTLiBFdmVyeXRoaW5nIGhhcyBiZWVuIGludGVncmF0ZWQg aW50bwo+ID4gbGludXgtbmV4dCBhdCBsZWFzdC4KPiAKPiB2Ni41LXJjMiBzaG93cyB0aGUgaXNz dWUgSSd2ZSBiZWVuIGRpc2N1c3NpbmcgYnV0IGxpbnV4LW5leHQKPiBuZXh0LTIwMjMwNzE4IGRv ZXNuJ3QgZXZlbiBwcm9iZSBtaXBpLWNzaSBhbmQgSSdtIG5vdCBjbGVhciB3aHkgeWV0Ogo+IAo+ IHdpdGggbGludXgtbmV4dCBuZXh0LTIwMjMwNzE4Ogo+ICMgZG1lc2cgfCBncmVwIGNzaQo+IFsg ICAgMS4xNzI3MTFdIGlteDctY3NpIDMyZTIwMDAwLmNzaTogUmVnaXN0ZXJlZCBjc2kgY2FwdHVy ZSBhcyAvZGV2L3ZpZGVvMAo+IFsgICAgMS4xNzk2NzRdIGlteDctY3NpIDMyZTIwMDAwLmNzaTog ZXJyb3IgLUVOT1RDT05OOiBGYWlsZWQgdG8gZ2V0Cj4gcmVtb3RlIGVuZHBvaW50Cj4gWyAgICAx LjE4NzUxM10gaW14Ny1jc2k6IHByb2JlIG9mIDMyZTIwMDAwLmNzaSBmYWlsZWQgd2l0aCBlcnJv ciAtMTA3Cj4gWyAgICAxLjc1NzY5M10gaTJjIDItMDAxMDogRml4ZWQgZGVwZW5kZW5jeSBjeWNs ZShzKSB3aXRoCj4gL3NvY0AwL2J1c0AzMmMwMDAwMC9taXBpLWNzaUAzMmUzMDAwMC9wb3J0cy9w b3J0QDAvZW5kcG9pbnQKPiBbICAgMTYuMzUyMDQ4XSBwbGF0Zm9ybSAzMmUzMDAwMC5taXBpLWNz aTogZGVmZXJyZWQgcHJvYmUgcGVuZGluZwo+ICMgY2F0IC9zeXMva2VybmVsL2RlYnVnL2Rldmlj ZXNfZGVmZXJyZWQKPiAzMmUzMDAwMC5taXBpLWNzaSAgICAgICBwbGF0Zm9ybTogd2FpdCBmb3Ig c3VwcGxpZXIKPiAvc29jQDAvYnVzQDMyYzAwMDAwL2NzaUAzMmUyMDAwMC9wb3J0L2VuZHBvaW50 Cj4gCj4gSW4gdGhpcyB0cmVlIGJvdGggZHJpdmVycy9tZWRpYS9pMmMvaW14MjE5LmMgYW5kCj4g ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9ueHAvaW14Ny1tZWRpYS1jc2kuYyBhcmUgYXQgdGhlIHNh bWUgcGF0Y2gKPiBsZXZlbCBhbmQgSSdtIG5vdCBzdXJlIHdoYXQgZWxzZSBpcyBpbnZvbHZlZCBo ZXJlIHRvIGxvb2sgYXQuCj4gCj4gSXQgc2VlbXMgbWlwaS1kc2kgYW5kIG1pcGktY3NpIGFyZSBl eHRyZW1lbHkgZnJhZ2lsZSBhbmQgcmVxdWlyZQo+IGNvbnN0YW50IHJlZ3Jlc3Npb24gdGVzdGlu ZyB1bmZvcnR1bmF0ZWx5Lgo+IAo+IGJlc3QgcmVnYXJkcywKPiAKPiBUaW0KCgotLSAKVFEtU3lz dGVtcyBHbWJIIHwgTcO8aGxzdHJhw59lIDIsIEd1dCBEZWxsaW5nIHwgODIyMjkgU2VlZmVsZCwg R2VybWFueQpBbXRzZ2VyaWNodCBNw7xuY2hlbiwgSFJCIDEwNTAxOApHZXNjaMOkZnRzZsO8aHJl cjogRGV0bGVmIFNjaG5laWRlciwgUsO8ZGlnZXIgU3RhaGwsIFN0ZWZhbiBTY2huZWlkZXIKaHR0 cDovL3d3dy50cS1ncm91cC5jb20vCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E039EB64DA for ; Thu, 20 Jul 2023 06:49:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231171AbjGTGtL (ORCPT ); Thu, 20 Jul 2023 02:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbjGTGtK (ORCPT ); Thu, 20 Jul 2023 02:49:10 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CAEB12F for ; Wed, 19 Jul 2023 23:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1689835744; x=1721371744; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WZ3v3utVO0Zb95j6GDnt+exK2K/OuKT5kKWXUw3dTW4=; b=nigP4TAJzt4QYRmo5qkkENVPJeGXPn9vNtdI9m1OYkTAe14YY3trcVzh 3QI4hu7bZu21hgvI4/fEhgkgtS8uhGswR0dVIhWbGK1X0diT3v9xvHANw C0aO0H5x6/AdxgexxxIxsiHxN9PLmKbnBXHkJY9+EXeS602t7dkNH/O/e LrctmpxkDpEkn5+P80N8mKToviPbO65Ifjqbo/Zv2TuzfJTpWctlXsIRd UOdr3gnM6gms/wjFSvQPgw3FEGR/bSjr4bTbeiqAAEhaL2glYHkQ9eZ67 W80DJWqwyOI79Og4DYMGOOBsxZRmpreMqo7Q3jfVydZ1zVgGOtmNdAYAk Q==; X-IronPort-AV: E=Sophos;i="6.01,218,1684792800"; d="scan'208";a="32023041" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 20 Jul 2023 08:49:01 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 57989280078; Thu, 20 Jul 2023 08:49:01 +0200 (CEST) From: Alexander Stein To: Tim Harvey Cc: Pengutronix Kernel Team , NXP Linux Team , linux-media , Linux ARM Mailing List , Fabio Estevam , Sascha Hauer , Mauro Carvalho Chehab , Rui Miguel Silva , Shawn Guo , Laurent Pinchart , Schrempf Frieder Subject: Re: media: imx: imx7-media-csi: Get rid of superfluous call to imx7_csi_mbus_fm t_to_pix_fmt Date: Thu, 20 Jul 2023 08:49:00 +0200 Message-ID: <844922189.0ifERbkFSE@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <2290635.ElGaqSPkdT@steina-w> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Tim, Am Mittwoch, 19. Juli 2023, 19:27:54 CEST schrieb Tim Harvey: > On Mon, Jul 17, 2023 at 2:57=E2=80=AFAM Alexander Stein >=20 > wrote: > > Hi Tim, > >=20 > > Am Freitag, 14. Juli 2023, 03:34:15 CEST schrieb Tim Harvey: > > > Alexander, > > >=20 > > > I found that commit 6f482c4729d9: ("media: imx: imx7-media-csi: Get > > > rid of superfluous call to imx7_csi_mbus_fmt_to_pix_fmt") introduced > > > an issue causing me to not be able to capture anymore on an imx8mm > > > with an imx219 camera. > > >=20 > > > I'm using a RaspberryPi Camera v2 which has an IMX219 8MP camera modu= le: > > > - https://datasheets.raspberrypi.com/camera/camera-v2-schematics.pdf > > > - has its own on-board 24MHz osc so no clock required from baseboard > > > - pin 11 enables 1.8V and 2.8V LDO which is connected to a GPIO I use > > > as a regulator enable > > >=20 > > > I'm using the imx8mm-venice-gw72xx-0x-imx219 dt overlay [1] to test > > > this. > > >=20 > > > Here is some additional information about how I'm using the camera > > > module: > > > # cat /sys/bus/media/devices/media*/model > > > imx-media > > > hantro-vpu > > > hantro-vpu > > > # cat /sys/class/video4linux/video*/name > > > csi capture > > > nxp,imx8mm-vpu-g1-dec > > > nxp,imx8mq-vpu-g2-dec > > > # enable imx219 to csi link > > > media-ctl --reset > > > media-ctl -l "'imx219 2-0010':0 -> 'csis-32e30000.mipi-csi':0 [1]" > > > # configure for 640x480 raw8 > > > media-ctl -v -V "'imx219 2-0010':0 [fmt:SRGGB8/640x480 field:none]" > > > media-ctl -v -V "'csis-32e30000.mipi-csi':0 [fmt:SRGGB8/640x480 > > > field:none]" media-ctl -v -V "'csi':0 [fmt:SRGGB8/640x480 field:none]" > > > # configure for RGGB (8-bit bayer), 640x480 resolution > > > v4l2-ctl --device /dev/video0 > > > --set-fmt-video=3Dwidth=3D640,height=3D480,pixelformat=3DRGGB --verbo= se > > >=20 > > > before commit 6f482c4729d9: ("media: imx: imx7-media-csi: Get rid of > > > superfluous call to imx7_csi_mbus_fmt_to_pix_fmt") this would report > > > back 640x480 resolution: > > > VIDIOC_QUERYCAP: ok > > > VIDIOC_G_FMT: ok > > > VIDIOC_S_FMT: ok > > >=20 > > > Format Video Capture: > > > Width/Height : 640/480 > > > Pixel Format : 'RGGB' (8-bit Bayer RGRG/GBGB) > > > Field : None > > > Bytes per Line : 640 > > > Size Image : 307200 > > > Colorspace : Default > > > Transfer Function : Default (maps to Rec. 709) > > > YCbCr/HSV Encoding: Default (maps to ITU-R 601) > > > Quantization : Default (maps to Full Range) > > >=20 > > > Flags : > > > And after the commit it reports back an invalid 768x480 resolution: > > > VIDIOC_QUERYCAP: ok > > > VIDIOC_G_FMT: ok > > > VIDIOC_S_FMT: ok > > >=20 > > > Format Video Capture: > > > Width/Height : 768/480 > > > Pixel Format : 'RGGB' (8-bit Bayer RGRG/GBGB) > > > Field : None > > > Bytes per Line : 768 > > > Size Image : 368640 > > > Colorspace : Default > > > Transfer Function : Default (maps to Rec. 709) > > > YCbCr/HSV Encoding: Default (maps to ITU-R 601) > > > Quantization : Default (maps to Full Range) > > >=20 > > > Flags : > > > This resolution and frame size mis-match causes issues for example > > > when using gstreamer to capture and stream frames. > >=20 > > Oh, that's weird. Can you check what the call to v4l_bound_align_image() > > inside __imx7_csi_video_try_fmt() is actually doing? Check walign, width > > before and after the call. From a glance that seems to be the only way > > width could be modified. >=20 > with debugging added in __imx7_csi_video_try_fmt: >=20 > root@jammy-venice:~# dmesg | grep csi > [ 0.038495] platform 32e30000.mipi-csi: Fixed dependency cycle(s) > with /soc@0/bus@32c00000/csi@32e20000/port/endpoint > [ 1.195055] __imx7_csi_video_try_fmt walign=3D4 bpp=3D16 640/480 > [ 1.200746] __imx7_csi_video_try_fmt walign=3D4 bpp=3D16 > bytesperline=3D1280 sizeimage=3D614400 640/480 > [ 1.209633] imx7-csi 32e20000.csi: Registered csi capture as /dev/vide= o0 > [ 1.775321] i2c 2-0010: Fixed dependency cycle(s) with > /soc@0/bus@32c00000/mipi-csi@32e30000/ports/port@0/endpoint > [ 2.010372] imx-mipi-csis 32e30000.mipi-csi: lanes: 2, freq: 333000000 > ^^^ this is kernel init and looks fine >=20 > # media-ctl -l "'imx219 2-0010':0 -> 'csis-32e30000.mipi-csi':0 [1]" > # media-ctl -v -V "'imx219 2-0010':0 [fmt:SRGGB8/640x480 field:none]" > # media-ctl -v -V "'csis-32e30000.mipi-csi':0 [fmt:SRGGB8/640x480 > field:none]" # media-ctl -v -V "'csi':0 [fmt:SRGGB8/640x480 field:none]" > ^^^ nothing changes here during link config (no calls to > __imx7_csi_video_try_fmt) >=20 > # v4l2-ctl --device /dev/video0 > --set-fmt-video=3Dwidth=3D640,height=3D480,pixelformat=3DRGGB --verbose > VIDIOC_QUERYCAP: ok > [ 120.367874] __imx7_csi_video_try_fmt walign=3D8 bpp=3D8 640/480 > ^^^ before calling v4l_bound_align_image() >=20 > VIDIOC_G_FMT: ok > [ 120.374974] __imx7_csi_video_try_fmt walign=3D8 bpp=3D8 > bytesperline=3D768 sizeimage=3D368640 768/480 > ^^^ after calling v4l_bound_align_image() width is changed from 640 to 768 So this call is the culprit, I noticed the important change to before. The= =20 alignment enforced in clamp_align(), called by v4l_bound_align_image(), is = a=20 multiple of 2^align, _not_ a multiple of align. So obviously 640 is increas= ed=20 to the next multiple of 2^8 (256) which is 768. Can you give the following= =20 diff a try? =2D-8<-- diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/ platform/nxp/imx7-media-csi.c index 2f9302fc7570..a040665eca7c 100644 =2D-- a/drivers/media/platform/nxp/imx7-media-csi.c +++ b/drivers/media/platform/nxp/imx7-media-csi.c @@ -1137,9 +1137,8 @@ __imx7_csi_video_try_fmt(struct v4l2_pix_format *pixf= mt, * TODO: Implement configurable stride support. */ walign =3D 8 * 8 / cc->bpp; =2D v4l_bound_align_image(&pixfmt->width, 1, 0xffff, walign, =2D &pixfmt->height, 1, 0xffff, 1, 0); =2D + pixfmt->width =3D clamp_roundup(pixfmt->width, 1, 0xffff, walign); + pixfmt->height =3D clamp_roundup(pixfmt->width, 1, 0xffff, 1); pixfmt->bytesperline =3D pixfmt->width * cc->bpp / 8; pixfmt->sizeimage =3D pixfmt->bytesperline * pixfmt->height; pixfmt->field =3D V4L2_FIELD_NONE; =2D-8<-- Thanks and best regards, Alexander > VIDIOC_S_FMT: ok > Format Video Capture: > Width/Height : 768/480 > Pixel Format : 'RGGB' (8-bit Bayer RGRG/GBGB) > Field : None > Bytes per Line : 768 > Size Image : 368640 > Colorspace : Default > Transfer Function : Default (maps to Rec. 709) > YCbCr/HSV Encoding: Default (maps to ITU-R 601) > Quantization : Default (maps to Full Range) >=20 > Flags : > > > I noticed you have several outstanding patches pending for > > > imx7-media-csi... perhaps there is something there you already know of > > > that addresses this issue? > >=20 > > There nothing pending AFAICS. Everything has been integrated into > > linux-next at least. >=20 > v6.5-rc2 shows the issue I've been discussing but linux-next > next-20230718 doesn't even probe mipi-csi and I'm not clear why yet: >=20 > with linux-next next-20230718: > # dmesg | grep csi > [ 1.172711] imx7-csi 32e20000.csi: Registered csi capture as /dev/vide= o0 > [ 1.179674] imx7-csi 32e20000.csi: error -ENOTCONN: Failed to get > remote endpoint > [ 1.187513] imx7-csi: probe of 32e20000.csi failed with error -107 > [ 1.757693] i2c 2-0010: Fixed dependency cycle(s) with > /soc@0/bus@32c00000/mipi-csi@32e30000/ports/port@0/endpoint > [ 16.352048] platform 32e30000.mipi-csi: deferred probe pending > # cat /sys/kernel/debug/devices_deferred > 32e30000.mipi-csi platform: wait for supplier > /soc@0/bus@32c00000/csi@32e20000/port/endpoint >=20 > In this tree both drivers/media/i2c/imx219.c and > drivers/media/platform/nxp/imx7-media-csi.c are at the same patch > level and I'm not sure what else is involved here to look at. >=20 > It seems mipi-dsi and mipi-csi are extremely fragile and require > constant regression testing unfortunately. >=20 > best regards, >=20 > Tim =2D-=20 TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ= any Amtsgericht M=C3=BCnchen, HRB 105018 Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch= neider http://www.tq-group.com/