All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Gupta <pagupta@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: amit@kernel.org, mst@redhat.com, arnd@arndb.de,
	virtualization@lists.linux-foundation.org, jasowang@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] virtio_ring: packed ring: fix virtqueue_detach_unused_buf
Date: Thu, 8 Aug 2019 08:44:55 -0400 (EDT)	[thread overview]
Message-ID: <845593916.7427317.1565268295376.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190808124232.GA32144@kroah.com>


> On Thu, Aug 08, 2019 at 08:28:46AM -0400, Pankaj Gupta wrote:
> > 
> > 
> > > > This patch makes packed ring code compatible with split ring in
> > > > function
> > > > 'virtqueue_detach_unused_buf_*'.
> > > 
> > > What does that mean?  What does this "fix"?
> > 
> > Patch 1 frees the buffers When a port is unplugged from the virtio
> > console device. It does this with the help of
> > 'virtqueue_detach_unused_buf_split/packed'
> > function. For split ring case, corresponding function decrements avail ring
> > index.
> > For packed ring code, this functionality is not available, so this patch
> > adds the
> > required support and hence help to remove the unused buffer completely.
> 
> Explain all of this in great detail in the changelog comment.  What you
> have in there today does not make any sense.

Sure. Will try to put in more clear words.

Thanks,
Pankaj

> 
> thanks,
> 
> greg k-h
> 

  parent reply	other threads:[~2019-08-08 12:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 11:36 [PATCH v2 0/2] virtio_console: fix replug of virtio console port Pankaj Gupta
2019-08-08 11:36 ` Pankaj Gupta
2019-08-08 11:36 ` [PATCH v2 1/2] virtio_console: free unused buffers with port delete Pankaj Gupta
2019-08-08 11:55   ` Greg KH
2019-08-08 12:19     ` Pankaj Gupta
2019-08-08 12:19       ` Pankaj Gupta
2019-08-08 11:55   ` Greg KH
2019-08-08 11:36 ` Pankaj Gupta
2019-08-08 11:36 ` [PATCH v2 2/2] virtio_ring: packed ring: fix virtqueue_detach_unused_buf Pankaj Gupta
2019-08-08 11:56   ` Greg KH
2019-08-08 11:56   ` Greg KH
2019-08-08 12:28     ` Pankaj Gupta
2019-08-08 12:42       ` Greg KH
2019-08-08 12:44         ` Pankaj Gupta
2019-08-08 12:44         ` Pankaj Gupta [this message]
2019-08-08 12:42       ` Greg KH
2019-08-08 12:28     ` Pankaj Gupta
2019-08-08 11:36 ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=845593916.7427317.1565268295376.JavaMail.zimbra@redhat.com \
    --to=pagupta@redhat.com \
    --cc=amit@kernel.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.