All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David D. Kilzer" <ddkilzer@kilzer.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH] git-svn: fix fetch with deleted tag
Date: Sat, 14 Aug 2010 11:49:01 -0700 (PDT)	[thread overview]
Message-ID: <84607.29034.qm@web30003.mail.mud.yahoo.com> (raw)
In-Reply-To: <AANLkTinpLUyQP=6XktduWAmSHg3CgcT3Y7cMJ9FQ4by_@mail.gmail.com>

On Sat, August 14, 2010 at 7:52:48 AM, Ævar Arnfjörð Bjarmason wrote:


> On Sat, Aug 14, 2010 at 14:07, David D. Kilzer <ddkilzer@kilzer.net> wrote:
> >  +++ b/t/t9156-git-svn-fetch-deleted-tag-2.sh
> >  @@ -0,0 +1,45 @@
> > +#!/bin/sh
> > +
> > +test_description='git  svn fetch deleted tag 2'
> 
> Any reason not to include both of these in the  same file? Just to
> avoid having to manually reset the  repository?


It was easier to run the tests individually when working on them, and I was 
hesitant to combine the setup steps from each test since it wouldn't be as clear 
which steps were for which test in the future.  I realize this may be slower 
when running the tests, but it makes them easier to maintain, especially when 
one hasn't looked at the tests in a while.

Is there a nice way to reset the repository between steps?

Thanks for the feedback!  I've already applied your other suggestions.

Dave

  reply	other threads:[~2010-08-14 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14 14:07 [PATCH] git-svn: fix fetch with deleted tag David D. Kilzer
2010-08-14 14:52 ` Ævar Arnfjörð Bjarmason
2010-08-14 18:49   ` David D. Kilzer [this message]
2010-08-14 19:08     ` Ævar Arnfjörð Bjarmason
2010-08-15  6:55     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84607.29034.qm@web30003.mail.mud.yahoo.com \
    --to=ddkilzer@kilzer.net \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.