From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Rosen Penev <rosenp@gmail.com>, linux-sound@vger.kernel.org
Cc: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: acp: return irq error directly
Date: Fri, 7 Aug 2026 18:28:47 +0530 [thread overview]
Message-ID: <8463e770-9573-49e0-b51d-6b9fa264ae88@amd.com> (raw)
In-Reply-To: <20260807012408.55272-1-rosenp@gmail.com>
On 8/7/26 06:54, Rosen Penev wrote:
> platform_get_irq() returns multiple error codes. Return the irq directly
> instead of just -ENODEV.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> sound/soc/amd/acp-pcm-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
> index baf4b41e54df..e99588458ed8 100644
> --- a/sound/soc/amd/acp-pcm-dma.c
> +++ b/sound/soc/amd/acp-pcm-dma.c
> @@ -1292,7 +1292,7 @@ static int acp_audio_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return -ENODEV;
> + return irq;
>
> status = devm_request_irq(&pdev->dev, irq, dma_irq_handler,
> 0, "ACP_IRQ", &pdev->dev);
next prev parent reply other threads:[~2026-08-07 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 1:24 [PATCH] ASoC: amd: acp: return irq error directly Rosen Penev
2026-08-07 12:58 ` Mukunda,Vijendar [this message]
2026-08-07 16:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8463e770-9573-49e0-b51d-6b9fa264ae88@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.