Re: [Qemu-devel] [PATCH] ui/spice: support websockets ports

[Alon Levy <alevy@redhat.com>]

> On 10/19/12 13:52, Alon Levy wrote:
> > Signed-off-by: Alon Levy <alevy@redhat.com>
> > ---
> > Spice package is not yet available, I assumed it will be the next
> > version, 0.12.1, for the added API spice_server_set_ws_ports.
> > Patches are on spice-devel and git is at
> > http://cgit.freedesktop.org/~alon/spice master branch
> > (db5817a059d640fb4ca21740e1362fc6c3e98765)
> 
> What is the state of this? Committed to spice-server meanwhile?

No, It doesn't work well enough, and I don't have time to fix it.

> 
> > --- a/roms/openbios
> > +++ b/roms/openbios
> > @@ -1 +1 @@
> > -Subproject commit f095c858136896d236931357b8d597f407286f71
> > +Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434
> 
> Hmm?

Yes, my bad.

> 
> > diff --git a/ui/spice-core.c b/ui/spice-core.c
> > index 5147365..190b14d 100644
> > --- a/ui/spice-core.c
> > +++ b/ui/spice-core.c
> > @@ -542,6 +542,14 @@ static void vm_change_state_handler(void
> > *opaque, int running,
> >      }
> >  }
> >  
> > +static void validate_port(int port, const char *port_name)
> > +{
> > +    if (port < 0 || port > 65535) {
> > +        error_report("spice %s is out of range", port_name);
> > +        exit(1);
> > +    }
> > +}
> 
> That should go as separate patch.

OK.

> 
> cheers.
>   Gerd
> 
>