From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F10A2C433DF for ; Mon, 20 Jul 2020 22:41:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53B722080D for ; Mon, 20 Jul 2020 22:41:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="EbRcxGT2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y54+52P/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53B722080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C1EAF83B; Tue, 21 Jul 2020 00:40:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C1EAF83B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595284882; bh=uNNT8JtJvtLpWMRVzssfYsOaESN4ASu9B1lx3s8VPXo=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EbRcxGT21Q0HZzHappSUAMDmUm0pM2F5t9WTOVPYMGu/c06X7OFkh1+hHe6sXFa8g IS4F75z/MI3bQAsW8t3V8R9EgJxZqacCxlKCIyuhEUS/0kQnAvEjcD7n5+aDZATRQa Y4wRTBo7cb2sTictaC1inzKR+IebsnLH4Y95erT8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3E113F800C1; Tue, 21 Jul 2020 00:40:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 81359F800F5; Tue, 21 Jul 2020 00:40:30 +0200 (CEST) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 76693F800C1 for ; Tue, 21 Jul 2020 00:40:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 76693F800C1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y54+52P/" Received: by mail-wr1-x431.google.com with SMTP id b6so19312777wrs.11 for ; Mon, 20 Jul 2020 15:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tdzStXPHhn/lPCcmGPCaBvtaXY8ZKM9Cp45GAKfxt9s=; b=Y54+52P/XnjtilisJNCnGinNUWBD1b9Cvz+O4isdAveWxDMPbnyfUL7l8PH2vQGasT vl3INNIKsFFzrET9BFHvb+Ue0N3aZ4z75lX0PzZpTLERLsjAXYUd84XeeCJt+whtg/n+ AzY6AQ64NTNFlEgiVdsU6QsgFUBdbR2SjY+cAGcED1wahHvRR8vY5/ICQ9L4an3LDNVC /k3EpFMu853pFmtQOWpfE/xLcgBsChLYtYfh1k2d+lqevnP98D0iDMW/11k5723XfJlD MuEksnUiyX+c/oF2wwGA43PgPCDU027fBzfMN8/XRYzdP+waUPU1Zvxwrg0fvUn05JNG 1PBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tdzStXPHhn/lPCcmGPCaBvtaXY8ZKM9Cp45GAKfxt9s=; b=CPkZ6avxldC9v6ZFHzVoQbUu7OligiIDXfrllLE7YP6g8GD1Vlca2bCmXDmMCDqNM3 4odnBMe1IgBtqhpe3V1xSAXE7J/VOCNL4mokEJ4ILkqM/7ZxYZ+yVgBNttFx2xRjgRQo EbSBAA7egrgVlVd9vJ97kXs6MckuwjRgehtnvWxTje0B+bZqmxRHEAqlEQ847Fy0MCty I80hZ7+ZXGSb7Jf+jhj6SnRaZVU1vKH2bTYKHZm372MENVg6xtFvb/7/MrH/+oI4RnqS nBO7eW5VpFPas6JwwOthyHSrWr8VpWuW7P5LtWdzK2JRzDadRcJYxcILsBb+LlFXpAXx ZJ2A== X-Gm-Message-State: AOAM533Hs+wnLgqjNEn0Jgk+zxxjXUaQb/f9Ox8MrLjsfhLljx8TOjRK 7fOGfo5nL8hBKVpHXTjQ6CE= X-Google-Smtp-Source: ABdhPJxMuvjHZthcawt8WUmiSHPwNllUGkXx5YnfTh7/mggvie8pQKteaMNu69ak3ikuRjX9cBkcVQ== X-Received: by 2002:a5d:4bc4:: with SMTP id l4mr22765783wrt.97.1595284819931; Mon, 20 Jul 2020 15:40:19 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.9]) by smtp.gmail.com with ESMTPSA id i67sm1153944wma.12.2020.07.20.15.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 15:40:19 -0700 (PDT) Subject: Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7 To: Tzung-Bi Shih References: From: Alper Nebi Yasak Message-ID: <846feea6-e2b6-3a0e-b05f-d70e898f9ea5@gmail.com> Date: Tue, 21 Jul 2020 01:40:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: ALSA development , Heiko Stuebner , Linux Kernel Mailing List , Takashi Iwai , Liam Girdwood , linux-rockchip@lists.infradead.org, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 17/07/2020 05:27, Tzung-Bi Shih wrote: > I am not convinced the pop comes from 128f825aeab7. Maybe some pre-existing defect in rk3399_gru_sound got exposed by 128f825aeab7 or the machine driver needs some changes to complement that commit? > (I don't have a rk3399-gru-kevin so I got another test machine with MAX98357A.) > (I was testing with and without an audio server.) Your observations are also a bit different from mine, which IMO also suggests the machine driver is the true culprit -- I'd guess the pops you hear would be from a different problem in your test machine's machine driver? (Let me restate my observations to contrast with yours, as I feel my previous explanation was too wordy:) > Observations: > - I can hear the pop either with or without 128f825aeab7 (with and > without sdmode-delay). I never hear pops without 128f825aeab7, but always hear pops with it. (no change when I remove "sdmode-delay" from the device-tree) > - The pop noise is not always. Higher probability after stopping > playback than before starting. I always hear one pop when starting playback, and two pops (with a few seconds between them) when stopping playback. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alper Nebi Yasak Subject: Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7 Date: Tue, 21 Jul 2020 01:40:14 +0300 Message-ID: <846feea6-e2b6-3a0e-b05f-d70e898f9ea5@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Tzung-Bi Shih Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , ALSA development , Linux Kernel Mailing List , linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org On 17/07/2020 05:27, Tzung-Bi Shih wrote: > I am not convinced the pop comes from 128f825aeab7. Maybe some pre-existing defect in rk3399_gru_sound got exposed by 128f825aeab7 or the machine driver needs some changes to complement that commit? > (I don't have a rk3399-gru-kevin so I got another test machine with MAX98357A.) > (I was testing with and without an audio server.) Your observations are also a bit different from mine, which IMO also suggests the machine driver is the true culprit -- I'd guess the pops you hear would be from a different problem in your test machine's machine driver? (Let me restate my observations to contrast with yours, as I feel my previous explanation was too wordy:) > Observations: > - I can hear the pop either with or without 128f825aeab7 (with and > without sdmode-delay). I never hear pops without 128f825aeab7, but always hear pops with it. (no change when I remove "sdmode-delay" from the device-tree) > - The pop noise is not always. Higher probability after stopping > playback than before starting. I always hear one pop when starting playback, and two pops (with a few seconds between them) when stopping playback.