From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-10.mta1.migadu.com (out-10.mta1.migadu.com [95.215.58.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61CBC1FB3E for ; Wed, 19 Jul 2023 18:16:43 +0000 (UTC) Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689790601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=37wHIIYI9DhPyoRy35JYAgFolie7lX9w1NPQmmBEsM4=; b=PV5S9nHt8mTA6K8/5qUDw/bcUbR8RiNWFpNSnHQe9JdX1CaR0Dvj+7SBu0Q5iBPXaxqtFm iwdN5iP5FeGMekbLIlp6Exeb7WUcRbKSKgKgx80wWUn+wGiT7usswbg59Kcl46cjcUCf+2 bE8CMdDSaEO0jeBMYmXsA6m7Ks3QsIY= Date: Wed, 19 Jul 2023 18:16:36 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Konstantin Ryabitsev" Message-ID: <847159ff6d0c01cef2e6308848ea49a732248e42@linux.dev> TLS-Required: No Subject: Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down. To: "Luben Tuikov" , "Asahi Lina" , "David Airlie" , "Daniel Vetter" , "Sumit Semwal" , "=?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?=" Cc: "Faith Ekstrand" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, "Alyssa Rosenzweig" , linux-media@vger.kernel.org In-Reply-To: <41efcbe5-e230-270f-53bb-90c703e9d3ad@amd.com> References: <41efcbe5-e230-270f-53bb-90c703e9d3ad@amd.com> <20230714-drm-sched-fixes-v1-0-c567249709f7@asahilina.net> <20230714-drm-sched-fixes-v1-3-c567249709f7@asahilina.net> <9343165f-2533-f363-4942-719ee9b7d2a4@amd.com> <99f9003f-d959-fff3-361a-25b2f47efc88@asahilina.net> <49a33f61-91b5-22ee-78b5-c7dd7c0d4a46@amd.com> <4587c699-5a59-d465-01f4-1bc2fbef7a12@asahilina.net> X-Migadu-Flow: FLOW_OUT July 18, 2023 at 1:14 AM, "Luben Tuikov" wrote: > > > Not sure about other drivers--they can speak for themselves and the= CC list > > > should include them--please use "dim add-missing-cc" and make sure > > > that the Git commit description contains the Cc tags--then git sen= d-email > > > will populate the SMTP CC. Feel free to add more Cc tags on top of= that. > >=20=20 >=20> I use `b4 prep -c` which I think does the same thing? I just ran i= t=20 >=20> again and it only added 'linaro-mm-sig@lists.linaro.org', not sure= why=20 >=20> that one wasn't there. Am I missing anything else? >=20 >=20Not sure about "b4 prep -c"--using "git send-email" instead, but what= is > important is to add the Cc: tags as part of the commit message. A "git = log" of > drm-misc-next shows the proper format. Then maintainers add Link: > tag to the correct email thread, which is usually completely automated > by "dim" or by "git am", or both. It's useful to note here that this is not standard practice across the en= tirety of the Linux tree. In general, Cc: trailers are added to individua= l commits when get_maintainer.pl wouldn't otherwise include someone in th= e recipient list. The "dim" tool mentioned here is specific to the DRM su= bsystem (the "d" stands for "DRM"). Since both tools work on git series, = you can use it alongside b4. DRM folks, if get_maintainer.pl isn't finding someone who should be inclu= ded on a series of patches, should the MAINTAINERS file be updated to mak= e it easier to submit valid patches without needing to know of "dim"? Regards, -K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58330EB64DA for ; Thu, 20 Jul 2023 10:23:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE1DB10E59D; Thu, 20 Jul 2023 10:23:25 +0000 (UTC) X-Greylist: delayed 573 seconds by postgrey-1.36 at gabe; Wed, 19 Jul 2023 18:26:17 UTC Received: from out-36.mta1.migadu.com (out-36.mta1.migadu.com [95.215.58.36]) by gabe.freedesktop.org (Postfix) with ESMTPS id E534310E086 for ; Wed, 19 Jul 2023 18:26:17 +0000 (UTC) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689790601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=37wHIIYI9DhPyoRy35JYAgFolie7lX9w1NPQmmBEsM4=; b=PV5S9nHt8mTA6K8/5qUDw/bcUbR8RiNWFpNSnHQe9JdX1CaR0Dvj+7SBu0Q5iBPXaxqtFm iwdN5iP5FeGMekbLIlp6Exeb7WUcRbKSKgKgx80wWUn+wGiT7usswbg59Kcl46cjcUCf+2 bE8CMdDSaEO0jeBMYmXsA6m7Ks3QsIY= Date: Wed, 19 Jul 2023 18:16:36 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Konstantin Ryabitsev" Message-ID: <847159ff6d0c01cef2e6308848ea49a732248e42@linux.dev> TLS-Required: No Subject: Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down. To: "Luben Tuikov" , "Asahi Lina" , "David Airlie" , "Daniel Vetter" , "Sumit Semwal" , "=?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?=" In-Reply-To: <41efcbe5-e230-270f-53bb-90c703e9d3ad@amd.com> References: <41efcbe5-e230-270f-53bb-90c703e9d3ad@amd.com> <20230714-drm-sched-fixes-v1-0-c567249709f7@asahilina.net> <20230714-drm-sched-fixes-v1-3-c567249709f7@asahilina.net> <9343165f-2533-f363-4942-719ee9b7d2a4@amd.com> <99f9003f-d959-fff3-361a-25b2f47efc88@asahilina.net> <49a33f61-91b5-22ee-78b5-c7dd7c0d4a46@amd.com> <4587c699-5a59-d465-01f4-1bc2fbef7a12@asahilina.net> X-Migadu-Flow: FLOW_OUT X-Mailman-Approved-At: Thu, 20 Jul 2023 10:23:05 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: asahi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Faith Ekstrand , Alyssa Rosenzweig , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" July 18, 2023 at 1:14 AM, "Luben Tuikov" wrote: > > > Not sure about other drivers--they can speak for themselves and the= CC list > > > should include them--please use "dim add-missing-cc" and make sure > > > that the Git commit description contains the Cc tags--then git sen= d-email > > > will populate the SMTP CC. Feel free to add more Cc tags on top of= that. > >=20=20 >=20> I use `b4 prep -c` which I think does the same thing? I just ran i= t=20 >=20> again and it only added 'linaro-mm-sig@lists.linaro.org', not sure= why=20 >=20> that one wasn't there. Am I missing anything else? >=20 >=20Not sure about "b4 prep -c"--using "git send-email" instead, but what= is > important is to add the Cc: tags as part of the commit message. A "git = log" of > drm-misc-next shows the proper format. Then maintainers add Link: > tag to the correct email thread, which is usually completely automated > by "dim" or by "git am", or both. It's useful to note here that this is not standard practice across the en= tirety of the Linux tree. In general, Cc: trailers are added to individua= l commits when get_maintainer.pl wouldn't otherwise include someone in th= e recipient list. The "dim" tool mentioned here is specific to the DRM su= bsystem (the "d" stands for "DRM"). Since both tools work on git series, = you can use it alongside b4. DRM folks, if get_maintainer.pl isn't finding someone who should be inclu= ded on a series of patches, should the MAINTAINERS file be updated to mak= e it easier to submit valid patches without needing to know of "dim"? Regards, -K