All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/2] bitbake.conf: Drop oldincludedir
Date: Thu, 16 Nov 2023 21:29:15 +0000	[thread overview]
Message-ID: <847e297330c0748c27926ceccde31f62f5ffed47.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1soCqH=+=QUeaF-ikMmwHCe0L0K8Cp_-X3tVqe6xTkQVFg@mail.gmail.com>

On Thu, 2023-11-16 at 13:25 -0800, Khem Raj wrote:
> On Thu, Nov 16, 2023 at 8:53 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > Autoconf defines this as:
> > 
> > "The directory for installing C header files for non-GCC compilers."
> > 
> > Whilst this is something autoconf does allow changing, I find it hard
> > to believe it has much use in the wild now and that headers don't get
> > split like this in reality, it would probably only be useful on really
> > old unixes.. The values are the same in our configuration anyway.
> > 
> > Drop the value and just use includedir everywhere.
> 
> Maybe alias it to includedir instead. Since some makefiles may assume
> a default value in its absence
> which might change the install behavior. It does not matter much on
> native builds but for cross builds it might.

I did for autoconf itself but I'm struggling to believe there are
generic makefiles out there using this.

We really need to cut down on the amount of environment exports we have
so lets see if this does actually break anything...

Cheers,

Richard


  reply	other threads:[~2023-11-16 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 16:52 [PATCH 1/2] bitbake.conf: Log events by default using BB_DEFAULT_EVENTLOG Richard Purdie
2023-11-16 16:52 ` [PATCH 2/2] bitbake.conf: Drop oldincludedir Richard Purdie
2023-11-16 21:25   ` [OE-core] " Khem Raj
2023-11-16 21:29     ` Richard Purdie [this message]
2023-11-16 21:31       ` Khem Raj
2023-11-20 21:38 ` [OE-core] [PATCH 1/2] bitbake.conf: Log events by default using BB_DEFAULT_EVENTLOG Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=847e297330c0748c27926ceccde31f62f5ffed47.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.