From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915, intel_ips: When i915 loads after IPS, make IPS relink to i915. Date: Thu, 23 Dec 2010 12:08:23 +0000 Message-ID: <849307$asqa8m@azsmga001.ch.intel.com> References: <1292899206-7331-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 38D989E938 for ; Thu, 23 Dec 2010 04:08:27 -0800 (PST) In-Reply-To: <1292899206-7331-1-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 20 Dec 2010 18:40:06 -0800, Eric Anholt wrote: > The IPS driver is designed to be able to run detached from i915 and > just not enable GPU turbo in that case, in order to avoid module > dependencies between the two drivers. This means that we don't know > what the load order between the two is going to be, and we had > previously only supported IPS after (optionally) i915, but not i915 > after IPS. If the wrong order was chosen, you'd get no GPU turbo, and > something like half the possible graphics performance. Applied to -fixes, thanks. -Chris -- Chris Wilson, Intel Open Source Technology Centre