From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] i915: restore only the mode of this driver on lastclose Date: Mon, 11 Apr 2011 18:31:21 +0100 Message-ID: <849307$cduht0@azsmga001.ch.intel.com> References: <1302499397-11051-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 1570A9EAFD for ; Mon, 11 Apr 2011 10:31:31 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Keith Packard , Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, 11 Apr 2011 09:06:38 -0700, Keith Packard wrote: > On Mon, 11 Apr 2011 15:23:17 +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > This has always used a big hammer, but that hammer is probably > > too big, I'm also not sure its necessary but at least this > > should be safe. > > Am I correct in reading the drm_fb_helper_restore path as restoring > the mode of each fbdev device in turn? If so, why would that ever be > useful (aside from doing it for each inserted card)? During panics? Just not lastclose. :) -Chris -- Chris Wilson, Intel Open Source Technology Centre