From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: reference counted forcewake Date: Tue, 19 Apr 2011 06:48:34 +0100 Message-ID: <849307$ci4e4q@azsmga001.ch.intel.com> References: <1302804827-11597-1-git-send-email-ben@bwidawsk.net> <1302804827-11597-5-git-send-email-ben@bwidawsk.net> <0d30dc$ls6j08@orsmga001.jf.intel.com> <20110418173143.GA10406@bwgnt.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 26E7C9E7EB for ; Mon, 18 Apr 2011 22:48:38 -0700 (PDT) In-Reply-To: <20110418173143.GA10406@bwgnt.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 18 Apr 2011 10:31:43 -0700, Ben Widawsky wrote: > I'll split the patches. I can also use the awake() variant for the > existing users, if you're okay with the awake() function (I was actually > expecting a comment from you on that). For the relevant functions, it > should be as simple as: > s/I915_READ32/i915_read32_awake > s/__gen6_gt_force_wake_/gen6_gt_force_wake_/ I did see the interface and also noted the absence of users... I'd like to see the patches to convert the current long sequences structured in such a way as to not break the current assumption that rc6 doesn't trigger in the middle. > Jesse has started the email to verify IIR is in fact a problem for us. > So I'll postpone resubmitting the patches until that's confirmed. That will be a relief and offer some simplifications no doubt... -Chris -- Chris Wilson, Intel Open Source Technology Centre