From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915/lvds: Only act on lid notify when the device is on Date: Fri, 22 Apr 2011 07:26:48 +0100 Message-ID: <849307$ck36v0@azsmga001.ch.intel.com> References: <20110421220803.10321.68968.stgit@localhost6.localdomain6> <1bdc18$kanhdf@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id F1B959E73F for ; Thu, 21 Apr 2011 23:26:51 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, 22 Apr 2011 16:13:27 +1000, Dave Airlie wrote: > On Fri, Apr 22, 2011 at 3:58 PM, Chris Wilson wrote: > > On Thu, 21 Apr 2011 16:08:14 -0600, Alex Williamson wrote: > >> If we're using vga switcheroo, the device may be turned off > >> and poking at it can cause an oops. > > > > I'm unfamiliar with what actually happens here after it is turned off. Can > > you post an OOPS for an example? > > The device will be in D3, so I'm guessing we read back some register > and get 0xFFFFFFFF, > and later fail. That's sounds reasonable. A bit of explanation does wonders if I (or anyone else reading through the history *or* code) ever encounter similar bug reports. Is anyone else concerned by the acpi_lid_notifier never being decoupled when the module is unloaded? And the randomness of int_lvds_connector? I love our code, every time you read it you find another bug. -Chris -- Chris Wilson, Intel Open Source Technology Centre