From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/7] drm/i915: automatic FDI training support for Ivy Bridge Date: Wed, 27 Apr 2011 07:19:52 +0100 Message-ID: <849307$cmdqsq@azsmga001.ch.intel.com> References: <1303861868-8805-1-git-send-email-jbarnes@virtuousgeek.org> <20110426170601.48fe675b@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id E06889E765 for ; Tue, 26 Apr 2011 23:19:56 -0700 (PDT) In-Reply-To: <20110426170601.48fe675b@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 26 Apr 2011 17:06:01 -0700, Jesse Barnes wrote: > You can ignore this set; I only sent it because I thought the others > wouldn't come through. Before I find the others... Do they treat IS_IVYBRIDGE() vs IS_GEN7 consistently? Do they have sufficient debug and self-tests? Can we split intel_enable_clock_gating() up into several "little" functions that address the peculiarity of each generation individually? -Chris -- Chris Wilson, Intel Open Source Technology Centre