From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FDCCC433DB for ; Thu, 4 Mar 2021 23:54:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72EB865001 for ; Thu, 4 Mar 2021 23:54:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231236AbhCDXyz (ORCPT ); Thu, 4 Mar 2021 18:54:55 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:1668 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbhCDXyy (ORCPT ); Thu, 4 Mar 2021 18:54:54 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 04 Mar 2021 15:54:54 -0800 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021 23:54:54 +0000 Received: from nvdebian.localnet (172.20.145.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021 23:54:51 +0000 From: Alistair Popple To: Zi Yan CC: , , , , , , , , , , , , Subject: Re: [PATCH v3 4/8] mm/rmap: Split migration into its own function Date: Fri, 5 Mar 2021 10:54:48 +1100 Message-ID: <84997524.IMQpRet0Aq@nvdebian> In-Reply-To: References: <20210226071832.31547-1-apopple@nvidia.com> <20210226071832.31547-5-apopple@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1614902094; bh=F3stMHCU+5ii6x1iy3omj83ayupI0P+Mr9dS1o5FIt0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type: X-Originating-IP:X-ClientProxiedBy; b=NpU2unlnheR6/rs4Zkq9TpQwW8Ut3zxi8Pn9daVGKPN2Zf3wm0lvYJ/fXsPnTrJ2C 8r6FecCuivTyRTi4tEnX/gdG9VaTETErNKJhNRJW79HRPU3l70FQFYUPIkhEgdY7tX YIlY/ILaZKek6pTrRHqTdQ0bbLwCKcvyZQIUXQp259KaTmOAv19PPuEro7v397+5Ru zN6MpkzlSUiIVTJVHly9G9jlXozppR3Xo1drI0n42SmVmEVacBDR8DiJef1PPXPiVo gD39vcJO1NY/MhM/r142FNOwKGLtl9ekatblvwVaSTLNgcdn4994m2D59bfjPvLnRH 5WIgHVadyysng== Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wednesday, 3 March 2021 9:08:15 AM AEDT Zi Yan wrote: > On 26 Feb 2021, at 2:18, Alistair Popple wrote: > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > > index 7f1ee411bd7b..77fa17de51d7 100644 > > --- a/include/linux/rmap.h > > +++ b/include/linux/rmap.h > > @@ -86,8 +86,6 @@ struct anon_vma_chain { > > }; > > > > enum ttu_flags { > > - TTU_MIGRATION =3D 0x1, /* migration mode */ > > - > > TTU_SPLIT_HUGE_PMD =3D 0x4, /* split huge PMD if any */ >=20 > It implies freeze in try_to_migrate() and no freeze in try_to_unmap(). I= =20 think > we need some comments here, above try_to_migrate(), and above try_to_unma= p() > to clarify the implication. Sure. This confused me for a bit and I was initially tempted to leave=20 TTU_SPLIT_FREEZE as a separate mode flag but looking at what freeze actuall= y=20 does it made sense to remove it because try_to_migrate() is for installing= =20 migration entries (which is what freeze does) and try_to_unmap() just unmap= s.=20 So I'll add some comments to that effect. =20 > > TTU_IGNORE_MLOCK =3D 0x8, /* ignore mlock */ > > TTU_IGNORE_HWPOISON =3D 0x20, /* corrupted page is recoverable */ > > @@ -96,7 +94,6 @@ enum ttu_flags { > > * do a final flush if necessary */ > > TTU_RMAP_LOCKED =3D 0x80, /* do not grab rmap lock: > > * caller holds it */ > > - TTU_SPLIT_FREEZE =3D 0x100, /* freeze pte under splitting thp */ > > }; > > > > #ifdef CONFIG_MMU > > @@ -193,6 +190,7 @@ static inline void page_dup_rmap(struct page *page,= =20 bool compound) > > int page_referenced(struct page *, int is_locked, > > struct mem_cgroup *memcg, unsigned long *vm_flags); > > > > +bool try_to_migrate(struct page *page, enum ttu_flags flags); > > bool try_to_unmap(struct page *, enum ttu_flags flags); > > > > /* Avoid racy checks */ > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index d00b93dc2d9e..357052a4567b 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2351,16 +2351,16 @@ void vma_adjust_trans_huge(struct vm_area_struc= t=20 *vma, > > > > static void unmap_page(struct page *page) > > { > > - enum ttu_flags ttu_flags =3D TTU_IGNORE_MLOCK | > > - TTU_RMAP_LOCKED | TTU_SPLIT_HUGE_PMD; > > + enum ttu_flags ttu_flags =3D TTU_RMAP_LOCKED | TTU_SPLIT_HUGE_PMD; > > bool unmap_success; > > > > VM_BUG_ON_PAGE(!PageHead(page), page); > > > > if (PageAnon(page)) > > - ttu_flags |=3D TTU_SPLIT_FREEZE; > > - > > - unmap_success =3D try_to_unmap(page, ttu_flags); > > + unmap_success =3D try_to_migrate(page, ttu_flags); > > + else > > + unmap_success =3D try_to_unmap(page, ttu_flags | > > + TTU_IGNORE_MLOCK); >=20 > I think we need a comment here about why anonymous pages need=20 try_to_migrate() > and others need try_to_unmap(). Historically this comes from baa355fd3314 ("thp: file pages support for=20 split_huge_page()") which says: "We don't setup migration entries. Just unmap pages. It helps handling case= s=20 when i_size is in the middle of the page: no need handle unmap pages beyond= =20 i_size manually." But I'll add a comment here, thanks. - Alistair > Thanks. >=20 > =E2=80=94 > Best Regards, > Yan Zi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF46C433E6 for ; Thu, 4 Mar 2021 23:54:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65B9D64FFF for ; Thu, 4 Mar 2021 23:54:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65B9D64FFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3BA66EA97; Thu, 4 Mar 2021 23:54:55 +0000 (UTC) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 008566EA96; Thu, 4 Mar 2021 23:54:54 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 04 Mar 2021 15:54:54 -0800 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021 23:54:54 +0000 Received: from nvdebian.localnet (172.20.145.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021 23:54:51 +0000 From: Alistair Popple To: Zi Yan Date: Fri, 5 Mar 2021 10:54:48 +1100 Message-ID: <84997524.IMQpRet0Aq@nvdebian> In-Reply-To: References: <20210226071832.31547-1-apopple@nvidia.com> <20210226071832.31547-5-apopple@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1614902094; bh=F3stMHCU+5ii6x1iy3omj83ayupI0P+Mr9dS1o5FIt0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type: X-Originating-IP:X-ClientProxiedBy; b=NpU2unlnheR6/rs4Zkq9TpQwW8Ut3zxi8Pn9daVGKPN2Zf3wm0lvYJ/fXsPnTrJ2C 8r6FecCuivTyRTi4tEnX/gdG9VaTETErNKJhNRJW79HRPU3l70FQFYUPIkhEgdY7tX YIlY/ILaZKek6pTrRHqTdQ0bbLwCKcvyZQIUXQp259KaTmOAv19PPuEro7v397+5Ru zN6MpkzlSUiIVTJVHly9G9jlXozppR3Xo1drI0n42SmVmEVacBDR8DiJef1PPXPiVo gD39vcJO1NY/MhM/r142FNOwKGLtl9ekatblvwVaSTLNgcdn4994m2D59bfjPvLnRH 5WIgHVadyysng== Subject: Re: [Nouveau] [PATCH v3 4/8] mm/rmap: Split migration into its own function X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcampbell@nvidia.com, daniel@ffwll.ch, linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hch@infradead.org, linux-mm@kvack.org, bskeggs@redhat.com, jgg@nvidia.com, akpm@linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" T24gV2VkbmVzZGF5LCAzIE1hcmNoIDIwMjEgOTowODoxNSBBTSBBRURUIFppIFlhbiB3cm90ZToK PiBPbiAyNiBGZWIgMjAyMSwgYXQgMjoxOCwgQWxpc3RhaXIgUG9wcGxlIHdyb3RlOgoKPiA+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3JtYXAuaCBiL2luY2x1ZGUvbGludXgvcm1hcC5oCj4g PiBpbmRleCA3ZjFlZTQxMWJkN2IuLjc3ZmExN2RlNTFkNyAxMDA2NDQKPiA+IC0tLSBhL2luY2x1 ZGUvbGludXgvcm1hcC5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4L3JtYXAuaAo+ID4gQEAgLTg2 LDggKzg2LDYgQEAgc3RydWN0IGFub25fdm1hX2NoYWluIHsKPiA+ICB9Owo+ID4KPiA+ICBlbnVt IHR0dV9mbGFncyB7Cj4gPiAtCVRUVV9NSUdSQVRJT04JCT0gMHgxLAkvKiBtaWdyYXRpb24gbW9k ZSAqLwo+ID4gLQo+ID4gIAlUVFVfU1BMSVRfSFVHRV9QTUQJPSAweDQsCS8qIHNwbGl0IGh1Z2Ug UE1EIGlmIGFueSAqLwo+IAo+IEl0IGltcGxpZXMgZnJlZXplIGluIHRyeV90b19taWdyYXRlKCkg YW5kIG5vIGZyZWV6ZSBpbiB0cnlfdG9fdW5tYXAoKS4gSSAKdGhpbmsKPiB3ZSBuZWVkIHNvbWUg Y29tbWVudHMgaGVyZSwgYWJvdmUgdHJ5X3RvX21pZ3JhdGUoKSwgYW5kIGFib3ZlIHRyeV90b191 bm1hcCgpCj4gdG8gY2xhcmlmeSB0aGUgaW1wbGljYXRpb24uCgpTdXJlLiBUaGlzIGNvbmZ1c2Vk IG1lIGZvciBhIGJpdCBhbmQgSSB3YXMgaW5pdGlhbGx5IHRlbXB0ZWQgdG8gbGVhdmUgClRUVV9T UExJVF9GUkVFWkUgYXMgYSBzZXBhcmF0ZSBtb2RlIGZsYWcgYnV0IGxvb2tpbmcgYXQgd2hhdCBm cmVlemUgYWN0dWFsbHkgCmRvZXMgaXQgbWFkZSBzZW5zZSB0byByZW1vdmUgaXQgYmVjYXVzZSB0 cnlfdG9fbWlncmF0ZSgpIGlzIGZvciBpbnN0YWxsaW5nIAptaWdyYXRpb24gZW50cmllcyAod2hp Y2ggaXMgd2hhdCBmcmVlemUgZG9lcykgYW5kIHRyeV90b191bm1hcCgpIGp1c3QgdW5tYXBzLiAK U28gSSdsbCBhZGQgc29tZSBjb21tZW50cyB0byB0aGF0IGVmZmVjdC4KIAo+ID4gIAlUVFVfSUdO T1JFX01MT0NLCT0gMHg4LAkvKiBpZ25vcmUgbWxvY2sgKi8KPiA+ICAJVFRVX0lHTk9SRV9IV1BP SVNPTgk9IDB4MjAsCS8qIGNvcnJ1cHRlZCBwYWdlIGlzIHJlY292ZXJhYmxlICovCj4gPiBAQCAt OTYsNyArOTQsNiBAQCBlbnVtIHR0dV9mbGFncyB7Cj4gPiAgCQkJCQkgKiBkbyBhIGZpbmFsIGZs dXNoIGlmIG5lY2Vzc2FyeSAqLwo+ID4gIAlUVFVfUk1BUF9MT0NLRUQJCT0gMHg4MCwJLyogZG8g bm90IGdyYWIgcm1hcCBsb2NrOgo+ID4gIAkJCQkJICogY2FsbGVyIGhvbGRzIGl0ICovCj4gPiAt CVRUVV9TUExJVF9GUkVFWkUJPSAweDEwMCwJCS8qIGZyZWV6ZSBwdGUgdW5kZXIgc3BsaXR0aW5n IHRocCAqLwo+ID4gIH07Cj4gPgo+ID4gICNpZmRlZiBDT05GSUdfTU1VCj4gPiBAQCAtMTkzLDYg KzE5MCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBwYWdlX2R1cF9ybWFwKHN0cnVjdCBwYWdlICpw YWdlLCAKYm9vbCBjb21wb3VuZCkKPiA+ICBpbnQgcGFnZV9yZWZlcmVuY2VkKHN0cnVjdCBwYWdl ICosIGludCBpc19sb2NrZWQsCj4gPiAgCQkJc3RydWN0IG1lbV9jZ3JvdXAgKm1lbWNnLCB1bnNp Z25lZCBsb25nICp2bV9mbGFncyk7Cj4gPgo+ID4gK2Jvb2wgdHJ5X3RvX21pZ3JhdGUoc3RydWN0 IHBhZ2UgKnBhZ2UsIGVudW0gdHR1X2ZsYWdzIGZsYWdzKTsKPiA+ICBib29sIHRyeV90b191bm1h cChzdHJ1Y3QgcGFnZSAqLCBlbnVtIHR0dV9mbGFncyBmbGFncyk7Cj4gPgo+ID4gIC8qIEF2b2lk IHJhY3kgY2hlY2tzICovCj4gPiBkaWZmIC0tZ2l0IGEvbW0vaHVnZV9tZW1vcnkuYyBiL21tL2h1 Z2VfbWVtb3J5LmMKPiA+IGluZGV4IGQwMGI5M2RjMmQ5ZS4uMzU3MDUyYTQ1NjdiIDEwMDY0NAo+ ID4gLS0tIGEvbW0vaHVnZV9tZW1vcnkuYwo+ID4gKysrIGIvbW0vaHVnZV9tZW1vcnkuYwo+ID4g QEAgLTIzNTEsMTYgKzIzNTEsMTYgQEAgdm9pZCB2bWFfYWRqdXN0X3RyYW5zX2h1Z2Uoc3RydWN0 IHZtX2FyZWFfc3RydWN0IAoqdm1hLAo+ID4KPiA+ICBzdGF0aWMgdm9pZCB1bm1hcF9wYWdlKHN0 cnVjdCBwYWdlICpwYWdlKQo+ID4gIHsKPiA+IC0JZW51bSB0dHVfZmxhZ3MgdHR1X2ZsYWdzID0g VFRVX0lHTk9SRV9NTE9DSyB8Cj4gPiAtCQlUVFVfUk1BUF9MT0NLRUQgfCBUVFVfU1BMSVRfSFVH RV9QTUQ7Cj4gPiArCWVudW0gdHR1X2ZsYWdzIHR0dV9mbGFncyA9IFRUVV9STUFQX0xPQ0tFRCB8 IFRUVV9TUExJVF9IVUdFX1BNRDsKPiA+ICAJYm9vbCB1bm1hcF9zdWNjZXNzOwo+ID4KPiA+ICAJ Vk1fQlVHX09OX1BBR0UoIVBhZ2VIZWFkKHBhZ2UpLCBwYWdlKTsKPiA+Cj4gPiAgCWlmIChQYWdl QW5vbihwYWdlKSkKPiA+IC0JCXR0dV9mbGFncyB8PSBUVFVfU1BMSVRfRlJFRVpFOwo+ID4gLQo+ ID4gLQl1bm1hcF9zdWNjZXNzID0gdHJ5X3RvX3VubWFwKHBhZ2UsIHR0dV9mbGFncyk7Cj4gPiAr CQl1bm1hcF9zdWNjZXNzID0gdHJ5X3RvX21pZ3JhdGUocGFnZSwgdHR1X2ZsYWdzKTsKPiA+ICsJ ZWxzZQo+ID4gKwkJdW5tYXBfc3VjY2VzcyA9IHRyeV90b191bm1hcChwYWdlLCB0dHVfZmxhZ3Mg fAo+ID4gKwkJCQkJCVRUVV9JR05PUkVfTUxPQ0spOwo+IAo+IEkgdGhpbmsgd2UgbmVlZCBhIGNv bW1lbnQgaGVyZSBhYm91dCB3aHkgYW5vbnltb3VzIHBhZ2VzIG5lZWQgCnRyeV90b19taWdyYXRl KCkKPiBhbmQgb3RoZXJzIG5lZWQgdHJ5X3RvX3VubWFwKCkuCgpIaXN0b3JpY2FsbHkgdGhpcyBj b21lcyBmcm9tIGJhYTM1NWZkMzMxNCAoInRocDogZmlsZSBwYWdlcyBzdXBwb3J0IGZvciAKc3Bs aXRfaHVnZV9wYWdlKCkiKSB3aGljaCBzYXlzOgoKIldlIGRvbid0IHNldHVwIG1pZ3JhdGlvbiBl bnRyaWVzLiBKdXN0IHVubWFwIHBhZ2VzLiBJdCBoZWxwcyBoYW5kbGluZyBjYXNlcyAKd2hlbiBp X3NpemUgaXMgaW4gdGhlIG1pZGRsZSBvZiB0aGUgcGFnZTogbm8gbmVlZCBoYW5kbGUgdW5tYXAg cGFnZXMgYmV5b25kIAppX3NpemUgbWFudWFsbHkuIgoKQnV0IEknbGwgYWRkIGEgY29tbWVudCBo ZXJlLCB0aGFua3MuCgogLSBBbGlzdGFpcgoKPiBUaGFua3MuCj4gCj4g4oCUCj4gQmVzdCBSZWdh cmRzLAo+IFlhbiBaaQoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3V2ZWF1 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC10C43381 for ; Thu, 4 Mar 2021 23:54:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1A0064FFD for ; Thu, 4 Mar 2021 23:54:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1A0064FFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA9D56EA96; Thu, 4 Mar 2021 23:54:55 +0000 (UTC) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 008566EA96; Thu, 4 Mar 2021 23:54:54 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 04 Mar 2021 15:54:54 -0800 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021 23:54:54 +0000 Received: from nvdebian.localnet (172.20.145.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Mar 2021 23:54:51 +0000 From: Alistair Popple To: Zi Yan Subject: Re: [PATCH v3 4/8] mm/rmap: Split migration into its own function Date: Fri, 5 Mar 2021 10:54:48 +1100 Message-ID: <84997524.IMQpRet0Aq@nvdebian> In-Reply-To: References: <20210226071832.31547-1-apopple@nvidia.com> <20210226071832.31547-5-apopple@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1614902094; bh=F3stMHCU+5ii6x1iy3omj83ayupI0P+Mr9dS1o5FIt0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type: X-Originating-IP:X-ClientProxiedBy; b=NpU2unlnheR6/rs4Zkq9TpQwW8Ut3zxi8Pn9daVGKPN2Zf3wm0lvYJ/fXsPnTrJ2C 8r6FecCuivTyRTi4tEnX/gdG9VaTETErNKJhNRJW79HRPU3l70FQFYUPIkhEgdY7tX YIlY/ILaZKek6pTrRHqTdQ0bbLwCKcvyZQIUXQp259KaTmOAv19PPuEro7v397+5Ru zN6MpkzlSUiIVTJVHly9G9jlXozppR3Xo1drI0n42SmVmEVacBDR8DiJef1PPXPiVo gD39vcJO1NY/MhM/r142FNOwKGLtl9ekatblvwVaSTLNgcdn4994m2D59bfjPvLnRH 5WIgHVadyysng== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcampbell@nvidia.com, linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hch@infradead.org, linux-mm@kvack.org, jglisse@redhat.com, bskeggs@redhat.com, jgg@nvidia.com, jhubbard@nvidia.com, akpm@linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkbmVzZGF5LCAzIE1hcmNoIDIwMjEgOTowODoxNSBBTSBBRURUIFppIFlhbiB3cm90ZToK PiBPbiAyNiBGZWIgMjAyMSwgYXQgMjoxOCwgQWxpc3RhaXIgUG9wcGxlIHdyb3RlOgoKPiA+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3JtYXAuaCBiL2luY2x1ZGUvbGludXgvcm1hcC5oCj4g PiBpbmRleCA3ZjFlZTQxMWJkN2IuLjc3ZmExN2RlNTFkNyAxMDA2NDQKPiA+IC0tLSBhL2luY2x1 ZGUvbGludXgvcm1hcC5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4L3JtYXAuaAo+ID4gQEAgLTg2 LDggKzg2LDYgQEAgc3RydWN0IGFub25fdm1hX2NoYWluIHsKPiA+ICB9Owo+ID4KPiA+ICBlbnVt IHR0dV9mbGFncyB7Cj4gPiAtCVRUVV9NSUdSQVRJT04JCT0gMHgxLAkvKiBtaWdyYXRpb24gbW9k ZSAqLwo+ID4gLQo+ID4gIAlUVFVfU1BMSVRfSFVHRV9QTUQJPSAweDQsCS8qIHNwbGl0IGh1Z2Ug UE1EIGlmIGFueSAqLwo+IAo+IEl0IGltcGxpZXMgZnJlZXplIGluIHRyeV90b19taWdyYXRlKCkg YW5kIG5vIGZyZWV6ZSBpbiB0cnlfdG9fdW5tYXAoKS4gSSAKdGhpbmsKPiB3ZSBuZWVkIHNvbWUg Y29tbWVudHMgaGVyZSwgYWJvdmUgdHJ5X3RvX21pZ3JhdGUoKSwgYW5kIGFib3ZlIHRyeV90b191 bm1hcCgpCj4gdG8gY2xhcmlmeSB0aGUgaW1wbGljYXRpb24uCgpTdXJlLiBUaGlzIGNvbmZ1c2Vk IG1lIGZvciBhIGJpdCBhbmQgSSB3YXMgaW5pdGlhbGx5IHRlbXB0ZWQgdG8gbGVhdmUgClRUVV9T UExJVF9GUkVFWkUgYXMgYSBzZXBhcmF0ZSBtb2RlIGZsYWcgYnV0IGxvb2tpbmcgYXQgd2hhdCBm cmVlemUgYWN0dWFsbHkgCmRvZXMgaXQgbWFkZSBzZW5zZSB0byByZW1vdmUgaXQgYmVjYXVzZSB0 cnlfdG9fbWlncmF0ZSgpIGlzIGZvciBpbnN0YWxsaW5nIAptaWdyYXRpb24gZW50cmllcyAod2hp Y2ggaXMgd2hhdCBmcmVlemUgZG9lcykgYW5kIHRyeV90b191bm1hcCgpIGp1c3QgdW5tYXBzLiAK U28gSSdsbCBhZGQgc29tZSBjb21tZW50cyB0byB0aGF0IGVmZmVjdC4KIAo+ID4gIAlUVFVfSUdO T1JFX01MT0NLCT0gMHg4LAkvKiBpZ25vcmUgbWxvY2sgKi8KPiA+ICAJVFRVX0lHTk9SRV9IV1BP SVNPTgk9IDB4MjAsCS8qIGNvcnJ1cHRlZCBwYWdlIGlzIHJlY292ZXJhYmxlICovCj4gPiBAQCAt OTYsNyArOTQsNiBAQCBlbnVtIHR0dV9mbGFncyB7Cj4gPiAgCQkJCQkgKiBkbyBhIGZpbmFsIGZs dXNoIGlmIG5lY2Vzc2FyeSAqLwo+ID4gIAlUVFVfUk1BUF9MT0NLRUQJCT0gMHg4MCwJLyogZG8g bm90IGdyYWIgcm1hcCBsb2NrOgo+ID4gIAkJCQkJICogY2FsbGVyIGhvbGRzIGl0ICovCj4gPiAt CVRUVV9TUExJVF9GUkVFWkUJPSAweDEwMCwJCS8qIGZyZWV6ZSBwdGUgdW5kZXIgc3BsaXR0aW5n IHRocCAqLwo+ID4gIH07Cj4gPgo+ID4gICNpZmRlZiBDT05GSUdfTU1VCj4gPiBAQCAtMTkzLDYg KzE5MCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBwYWdlX2R1cF9ybWFwKHN0cnVjdCBwYWdlICpw YWdlLCAKYm9vbCBjb21wb3VuZCkKPiA+ICBpbnQgcGFnZV9yZWZlcmVuY2VkKHN0cnVjdCBwYWdl ICosIGludCBpc19sb2NrZWQsCj4gPiAgCQkJc3RydWN0IG1lbV9jZ3JvdXAgKm1lbWNnLCB1bnNp Z25lZCBsb25nICp2bV9mbGFncyk7Cj4gPgo+ID4gK2Jvb2wgdHJ5X3RvX21pZ3JhdGUoc3RydWN0 IHBhZ2UgKnBhZ2UsIGVudW0gdHR1X2ZsYWdzIGZsYWdzKTsKPiA+ICBib29sIHRyeV90b191bm1h cChzdHJ1Y3QgcGFnZSAqLCBlbnVtIHR0dV9mbGFncyBmbGFncyk7Cj4gPgo+ID4gIC8qIEF2b2lk IHJhY3kgY2hlY2tzICovCj4gPiBkaWZmIC0tZ2l0IGEvbW0vaHVnZV9tZW1vcnkuYyBiL21tL2h1 Z2VfbWVtb3J5LmMKPiA+IGluZGV4IGQwMGI5M2RjMmQ5ZS4uMzU3MDUyYTQ1NjdiIDEwMDY0NAo+ ID4gLS0tIGEvbW0vaHVnZV9tZW1vcnkuYwo+ID4gKysrIGIvbW0vaHVnZV9tZW1vcnkuYwo+ID4g QEAgLTIzNTEsMTYgKzIzNTEsMTYgQEAgdm9pZCB2bWFfYWRqdXN0X3RyYW5zX2h1Z2Uoc3RydWN0 IHZtX2FyZWFfc3RydWN0IAoqdm1hLAo+ID4KPiA+ICBzdGF0aWMgdm9pZCB1bm1hcF9wYWdlKHN0 cnVjdCBwYWdlICpwYWdlKQo+ID4gIHsKPiA+IC0JZW51bSB0dHVfZmxhZ3MgdHR1X2ZsYWdzID0g VFRVX0lHTk9SRV9NTE9DSyB8Cj4gPiAtCQlUVFVfUk1BUF9MT0NLRUQgfCBUVFVfU1BMSVRfSFVH RV9QTUQ7Cj4gPiArCWVudW0gdHR1X2ZsYWdzIHR0dV9mbGFncyA9IFRUVV9STUFQX0xPQ0tFRCB8 IFRUVV9TUExJVF9IVUdFX1BNRDsKPiA+ICAJYm9vbCB1bm1hcF9zdWNjZXNzOwo+ID4KPiA+ICAJ Vk1fQlVHX09OX1BBR0UoIVBhZ2VIZWFkKHBhZ2UpLCBwYWdlKTsKPiA+Cj4gPiAgCWlmIChQYWdl QW5vbihwYWdlKSkKPiA+IC0JCXR0dV9mbGFncyB8PSBUVFVfU1BMSVRfRlJFRVpFOwo+ID4gLQo+ ID4gLQl1bm1hcF9zdWNjZXNzID0gdHJ5X3RvX3VubWFwKHBhZ2UsIHR0dV9mbGFncyk7Cj4gPiAr CQl1bm1hcF9zdWNjZXNzID0gdHJ5X3RvX21pZ3JhdGUocGFnZSwgdHR1X2ZsYWdzKTsKPiA+ICsJ ZWxzZQo+ID4gKwkJdW5tYXBfc3VjY2VzcyA9IHRyeV90b191bm1hcChwYWdlLCB0dHVfZmxhZ3Mg fAo+ID4gKwkJCQkJCVRUVV9JR05PUkVfTUxPQ0spOwo+IAo+IEkgdGhpbmsgd2UgbmVlZCBhIGNv bW1lbnQgaGVyZSBhYm91dCB3aHkgYW5vbnltb3VzIHBhZ2VzIG5lZWQgCnRyeV90b19taWdyYXRl KCkKPiBhbmQgb3RoZXJzIG5lZWQgdHJ5X3RvX3VubWFwKCkuCgpIaXN0b3JpY2FsbHkgdGhpcyBj b21lcyBmcm9tIGJhYTM1NWZkMzMxNCAoInRocDogZmlsZSBwYWdlcyBzdXBwb3J0IGZvciAKc3Bs aXRfaHVnZV9wYWdlKCkiKSB3aGljaCBzYXlzOgoKIldlIGRvbid0IHNldHVwIG1pZ3JhdGlvbiBl bnRyaWVzLiBKdXN0IHVubWFwIHBhZ2VzLiBJdCBoZWxwcyBoYW5kbGluZyBjYXNlcyAKd2hlbiBp X3NpemUgaXMgaW4gdGhlIG1pZGRsZSBvZiB0aGUgcGFnZTogbm8gbmVlZCBoYW5kbGUgdW5tYXAg cGFnZXMgYmV5b25kIAppX3NpemUgbWFudWFsbHkuIgoKQnV0IEknbGwgYWRkIGEgY29tbWVudCBo ZXJlLCB0aGFua3MuCgogLSBBbGlzdGFpcgoKPiBUaGFua3MuCj4gCj4g4oCUCj4gQmVzdCBSZWdh cmRzLAo+IFlhbiBaaQoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==