All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: Muneendra Kumar <muneendra.kumar@broadcom.com>,
	linux-scsi@vger.kernel.org
Cc: hare@suse.de, emilne@redhat.com, mkumar@redhat.com,
	Anil Gurumurthy <agurumurthy@marvell.com>,
	Nilesh Javali <njavali@marvell.com>
Subject: Re: [PATCH] scsi:scsi_transport_fc:Add an additional flag to fc_host_fpin_rcv()
Date: Thu, 9 Feb 2023 07:26:48 -0800	[thread overview]
Message-ID: <84a86eeb-c60b-aa3b-64cf-2dbc2aeffcc7@gmail.com> (raw)
In-Reply-To: <20230209034326.882514-1-muneendra.kumar@broadcom.com>

On 2/8/2023 7:43 PM, Muneendra Kumar wrote:
> From: Muneendra <muneendra.kumar@broadcom.com>
> 
> The LLDD and the stack currently process FPINs received from the fabric,
> but the stack is not aware of any action taken by the driver to alleviate
> congestion. The current interface between the driver and the SCSI stack is
> limited to passing the notification mainly for statistics and heuristics.
> 
> The reaction to an FPIN could be handled either by the driver or by the
> stack (marginal path and failover). This patch enhances the interface to
> indicate if action on an FPIN has already been reacted to by the
> LLDDs or not.Add an additional flag to fc_host_fpin_rcv() to indicate
> if the FPIN has been acknowledged/reacted to by the driver.
> 
> Also added a new event code FCH_EVT_LINK_FPIN_ACK to notify to the user
> that the event has been acknowledged/reacted by the LLDD driver
> 
> Signed-off-by: Anil Gurumurthy <agurumurthy@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> Signed-off-by: Muneendra <muneendra.kumar@broadcom.com>
> ---
>   drivers/scsi/lpfc/lpfc_els.c     |  2 +-
>   drivers/scsi/qla2xxx/qla_isr.c   |  2 +-
>   drivers/scsi/scsi_transport_fc.c | 10 +++++++---
>   include/scsi/scsi_transport_fc.h |  4 +++-
>   4 files changed, 12 insertions(+), 6 deletions(-)
> 

Reviewed-by: James Smart <jsmart2021@gmail.com>

Looks good.

Thanks

-- james



  reply	other threads:[~2023-02-09 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09  3:43 [PATCH] scsi:scsi_transport_fc:Add an additional flag to fc_host_fpin_rcv() Muneendra Kumar
2023-02-09 15:26 ` James Smart [this message]
2023-02-09 17:18 ` Himanshu Madhani
2023-02-09 19:32 ` Ewan Milne
2023-02-21 23:04 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84a86eeb-c60b-aa3b-64cf-2dbc2aeffcc7@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=agurumurthy@marvell.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkumar@redhat.com \
    --cc=muneendra.kumar@broadcom.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.