All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: Daehyeon Ko <4ncienth@gmail.com>, netdev@vger.kernel.org
Cc: David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] ip: validate options before echoing them
Date: Wed, 2 Sep 2026 17:29:39 +0800	[thread overview]
Message-ID: <84b011a3-7662-4f6e-ad4d-6bf81d2e1b30@linux.dev> (raw)
In-Reply-To: <20260902055802.3724915-1-4ncienth@gmail.com>


on 9/2/26 1:58 PM, Daehyeon Ko wrote:
> IPv4 option metadata stores absolute offsets from the network header in the
> skb control block. That metadata is only safe to use while it still
> describes the header at skb_network_header().
>
> This invariant can be broken in more than one way. An IPv6 UDP packet can
> remain queued while IPV6_ADDRFORM converts its socket to IPv4, after which


For IPV6_ADDRFORM, we already reject this operation if outgoing ipv6 
packets still exist.

case IPV6_ADDRFORM: ...... if (sk->sk_protocol == IPPROTO_UDP) { if 
(udp_sk(sk)->pending == AF_INET6) { retv = -EBUSY; break; }

May be we can also reject this operationif ipv6 skbs still exist in 
read/recv queue ?



  parent reply	other threads:[~2026-09-02  9:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  5:58 [PATCH net v3] ip: validate options before echoing them Daehyeon Ko
2026-09-02  8:44 ` Eric Dumazet
2026-09-02 15:53   ` Ido Schimmel
2026-09-02  9:29 ` Jiayuan Chen [this message]
2026-09-02 22:05 ` [syzbot ci] " syzbot ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84b011a3-7662-4f6e-ad4d-6bf81d2e1b30@linux.dev \
    --to=jiayuan.chen@linux.dev \
    --cc=4ncienth@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.