All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy MacLeod <randy.macleod@windriver.com>
To: sunilkumar.dora@windriver.com,
	openembedded-core@lists.openembedded.org,
	"steve@sakoman.com" <steve@sakoman.com>
Cc: Naveen.Gowda@windriver.com, Sundeep.Kokkonda@windriver.com
Subject: Re: [styhead][PATCH] Backport: Fix c++: tweak for Wrange-loop-construct
Date: Wed, 11 Dec 2024 15:11:16 -0500	[thread overview]
Message-ID: <84c2f3e5-e5ea-4a77-b62a-172d1057d14e@windriver.com> (raw)
In-Reply-To: <20241211172242.4040469-1-sunilkumar.dora@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2164 bytes --]

Steve,
Ignore this one, a v2 has been submitted.

Sunil,

Please follow-up on your own patches like this to help people know that
they should ignore a patch that you have sent. Steve has 10s of emails 
or more
to deal with so clear instructions are helpful.

For future commit revisions, please also indicate that the patch is v2, 
v3 again,
so that anyone reading your thread can follow along. Some people even thread
follow-ups to the initial commit using --in-reply-to=<identifier> but 
that's not required.

You can use:
    git send-email ... --subject-prefix="branch-foo][PATCH v2"
See:
https://lore.kernel.org/openembedded-core/?q=v2
and:
https://docs.yoctoproject.org/contributor-guide/submit-changes.html#sending-patches-via-email

Thanks,

../Randy


On 2024-12-11 12:22 p.m., sunilkumar.dora@windriver.com wrote:
> From: Sunil Dora<sunilkumar.dora@windriver.com>
>
> This commit updates the warning to use a check for "trivially constructible" instead of
> "trivially copyable." The original check was incorrect, as "trivially copyable" only applies
> to types that can be copied trivially, whereas "trivially constructible" is the correct check
> for types that can be trivially default-constructed.
>
> This change ensures the warning is more accurate and aligns with the proper type traits.
>
> LLVM accepted a similar fix:
> https://github.com/llvm/llvm-project/issues/47355
>
> PR c++/116731 [https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116731]
>
> Upstream-Status: Backport [https://gcc.gnu.org/g:6ac4e2f4b2ca9980670e7d3815a9140730df1005]
>
> Signed-off-by: Marek Polacek<polacek@redhat.com>
> Signed-off-by: Sunil Dora<sunilkumar.dora@windriver.com>
> ---
>   meta/recipes-devtools/gcc/gcc-14.2.inc        |   1 +
>   ...ix-c-tweak-for-Wrange-loop-construct.patch | 114 ++++++++++++++++++
>   2 files changed, 115 insertions(+)
>   create mode 100644 meta/recipes-devtools/gcc/gcc/0026-Backport-Fix-c-tweak-for-Wrange-loop-construct.patch
>
> diff --git a/meta/recipes-devtools/gcc/gcc-14.2.inc b/meta/recipes-devtools/gcc/gcc-14.2.inc
> ...


-- 
# Randy MacLeod
# Wind River Linux

[-- Attachment #2: Type: text/html, Size: 4286 bytes --]

      reply	other threads:[~2024-12-11 20:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 17:22 [styhead][PATCH] Backport: Fix c++: tweak for Wrange-loop-construct sunilkumar.dora
2024-12-11 20:11 ` Randy MacLeod [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84c2f3e5-e5ea-4a77-b62a-172d1057d14e@windriver.com \
    --to=randy.macleod@windriver.com \
    --cc=Naveen.Gowda@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    --cc=sunilkumar.dora@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.