From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [RFC][PATCH 4/4] drm: i915: Atomic pageflip WIP
Date: Fri, 14 Sep 2012 14:57:26 +0100
Message-ID: <84c8a8$5o3vcu@orsmga001.jf.intel.com>
References: <1347464827-14187-1-git-send-email-ville.syrjala@linux.intel.com>
	<1347464827-14187-5-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 54BC6A101B
	for <dri-devel@lists.freedesktop.org>;
	Fri, 14 Sep 2012 06:57:42 -0700 (PDT)
In-Reply-To: <1347464827-14187-5-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, 12 Sep 2012 18:47:07 +0300, ville.syrjala@linux.intel.com wrote:
> +static void intel_flip_finish(struct drm_flip *flip)
> +{
> +	struct intel_flip *intel_flip =
> +		container_of(flip, struct intel_flip, base);
> +	struct drm_device *dev = intel_flip->crtc->dev;
> +
> +	if (intel_flip->old_bo) {
> +		mutex_lock(&dev->struct_mutex);
> +
> +		intel_finish_fb(intel_flip->old_bo);

So if I understand correctly, this code is called after the flip is
already complete?

The intel_finish_fb() exists to flush pending batches and flips on the
current fb, prior to changing the scanout registers. (There is a
hardware dependency such that the GPU may be executing a command that
required the current modesetting.) In the case of flip completion, all
of those dependencies have already been retired and so the finish should
be a no-op. And so it should no be required, nor the changes to
intel_finish_fb (which should have included a change in the name to
indicate that is now taking the fb_obj).

> +		intel_unpin_fb_obj(intel_flip->old_bo);
> +
> +		mutex_unlock(&dev->struct_mutex);
> +	}
> +
> +}
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre