From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Mark hardware context support optional Date: Tue, 25 Sep 2012 21:46:47 +0100 Message-ID: <84c8a8$5sef3d@orsmga001.jf.intel.com> References: <1348581217-396-1-git-send-email-chris@chris-wilson.co.uk> <20120925120414.17ecffa4@bwidawsk.net> <275ffc$6o3v42@fmsmga002.fm.intel.com> <20120925133531.10d9a11b@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id CD6859F5E6 for ; Tue, 25 Sep 2012 13:46:54 -0700 (PDT) In-Reply-To: <20120925133531.10d9a11b@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 25 Sep 2012 13:35:31 -0700, Ben Widawsky wrote: > On Tue, 25 Sep 2012 20:41:45 +0100 > Chris Wilson wrote: > > > On Tue, 25 Sep 2012 12:04:14 -0700, Ben Widawsky > > wrote: > > > On Tue, 25 Sep 2012 14:53:37 +0100 > > > Chris Wilson wrote: > > > > > > > "Enable hardware context support for userspace (default: > > > > disabled))"); > > > > > > You've found one platform this doesn't work on, and a bunch of > > > features rely on this, and yet we default to disabled? That seems a > > > bit harsh to me. > > > > Exactly, it's meant to be harsh. In the limited testing that hw > > contexts have been exposed to, we have a number of hangs for which > > they are implicated. Therefore they are not safe to enable yet... > > Unless you can prove otherwise. :-p > > -Chris > > > > The reason I've always resisted a module parameter is that rc6 and > contexts are tied so very closely together. We've had a number of > issues around rc6 already, I do not want contexts to be conflated with > those issues. It's interesting if rc6=0 and failures still occur. I've > yet to hear of such an issue, but I'd like to know if that's the case > here. Disabling rc6 but keeping hw contexts works but regresses performance in old school games. rc6=0 hw_contexts=0 -> works rc6=0 hw_contexts=1 -> works rc6=1 hw_contexts=0 -> works (current default up to 3.6) rc6=1 hw_contexts=1 -> hard hang with gl (new default in 3.6) -Chris -- Chris Wilson, Intel Open Source Technology Centre