From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Respect HW RC6 states availability Date: Wed, 24 Oct 2012 22:33:23 +0100 Message-ID: <84c8a8$68hfcj@orsmga001.jf.intel.com> References: <1351105282-26499-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id B1455A0309 for ; Wed, 24 Oct 2012 14:33:55 -0700 (PDT) In-Reply-To: <1351105282-26499-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 24 Oct 2012 17:01:22 -0200, Rodrigo Vivi wrote: > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 50f5809..a8c6c08 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -2370,7 +2370,7 @@ static void gen6_disable_rps(struct drm_device *dev) > int intel_enable_rc6(const struct drm_device *dev) > { > /* Respect the kernel parameter if it is set */ > - if (i915_enable_rc6 >= 0) > + if (i915_enable_rc6 = 0) This doesn't do what you want. -Chris -- Chris Wilson, Intel Open Source Technology Centre