From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: LVDS fallback to fixed-mode if EDID not present Date: Thu, 22 Nov 2012 16:36:13 +0000 Message-ID: <84c8a8$6kpes4@orsmga001.jf.intel.com> References: <1353514444-5771-1-git-send-email-chris@chris-wilson.co.uk> <1353514444-5771-2-git-send-email-chris@chris-wilson.co.uk> <87k3tdd2yc.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id DF30BE5EEB for ; Thu, 22 Nov 2012 08:36:43 -0800 (PST) In-Reply-To: <87k3tdd2yc.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 22 Nov 2012 18:20:27 +0200, Jani Nikula wrote: > On Wed, 21 Nov 2012, Chris Wilson wrote: > > > > mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode); > > if (mode == NULL) > > @@ -1065,8 +1060,6 @@ bool intel_lvds_init(struct drm_device *dev) > > kfree(edid); > > edid = ERR_PTR(-EINVAL); > > } > > - } else { > > - edid = ERR_PTR(-ENOENT); > > I'd like to keep this though. I was thinking a more generic, future EDID > caching feature might use the difference between -EINVAL and -ENOENT, > NULL being the "we just haven't read it yet" flag, to prevent trying to > re-read the EDID when it isn't there. *shrug*. Okay, that's a reasonable argument. Daniel feel free to drop this hunk. -Chris -- Chris Wilson, Intel Open Source Technology Centre