From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fixup overlay stolen memory leak Date: Tue, 18 Dec 2012 14:48:39 +0000 Message-ID: <84c8a8$70rcbb@orsmga001.jf.intel.com> References: <1355840677-678-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 5755BE62C7 for ; Tue, 18 Dec 2012 06:48:59 -0800 (PST) In-Reply-To: <1355840677-678-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 18 Dec 2012 15:24:37 +0100, Daniel Vetter wrote: > We need to clean up the overlay first, before taking down the > stolen memory allocator. > > This regression has been introducec in > > commit 8040513870399f1cb032cb8bc805df5042fedcdf > Author: Chris Wilson > Date: Thu Nov 15 11:32:29 2012 +0000 > > drm/i915: Allocate overlay registers from stolen memory > > Note: This is just a quick hack to shut up a warning in the module > unload code, so that I can check again whether we don't leak any > framebuffers. > > v2: Rework the patch a bit as suggested by Chris Wilson: > - move the overlay teardown up, into the modeset cleanup > - move the stolen mm takedown into i915_gem_cleanup_stolen > > Cc: Chris Wilson > Signed-off-by: Daniel Vetter That organisation indeed makes more sense. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre