From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/3] drm/i915; Protect intel_gen4_compute_offset_xtiled() against unknown pixel format Date: Tue, 08 Jan 2013 11:31:28 +0000 Message-ID: <84c8a8$783p4q@orsmga001.jf.intel.com> References: <1355868794-3708-1-git-send-email-chris@chris-wilson.co.uk> <20130108111350.GZ5737@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D826E60BB for ; Tue, 8 Jan 2013 03:31:33 -0800 (PST) In-Reply-To: <20130108111350.GZ5737@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 8 Jan 2013 12:13:50 +0100, Daniel Vetter wrote: > On Tue, Dec 18, 2012 at 10:13:12PM +0000, Chris Wilson wrote: > > If the pixel format is not known to the core helpers, it fills in the > > fb->bits_per_pixel field as 0. This causes a fatal divide-by-zero OOPS > > when we then try to calculate the tiled offset. This would not be a > > problem, but that the core helpers do not know about the YUV planar > > formats we use for sprites. > > > > Signed-off-by: Chris Wilson > > Do we still need this one with the s/fb->bits_per_pixel/pixel_size/ change > in one of the later patches? I don't believe so, we fixed up the only known issue in the sprite code, and for the time being we only have rgb primary display planes. -Chris -- Chris Wilson, Intel Open Source Technology Centre