All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Alejandro Vallejo <alejandro.vallejo@cloud.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Anthony PERARD" <anthony.perard@vates.tech>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 2/2] tools/hvmloader: Replace LAPIC_ID() with cpu_to_apicid[]
Date: Tue, 4 Feb 2025 16:07:29 +0100	[thread overview]
Message-ID: <84c8d20e-b9f1-4593-b5df-86cc00ff33b5@suse.com> (raw)
In-Reply-To: <20250204144542.7399-3-alejandro.vallejo@cloud.com>

On 04.02.2025 15:45, Alejandro Vallejo wrote:
> --- a/tools/firmware/hvmloader/config.h
> +++ b/tools/firmware/hvmloader/config.h
> @@ -48,8 +48,9 @@ extern uint8_t ioapic_version;
>  
>  #define IOAPIC_ID           0x01
>  
> +extern uint32_t *cpu_to_apicid;

Strictly speaking this ought to be part of the earlier patch. If hvmloader
was Misra-checked, this would be a (transient) violation.

config.h is also somewhat odd a place to put this declaration, yet then I
can't really suggest anything better.

Jan



  reply	other threads:[~2025-02-04 15:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 14:45 [PATCH v2 0/2] tools/hvmloader: Decouple APIC IDs from vCPU IDs Alejandro Vallejo
2025-02-04 14:45 ` [PATCH v2 1/2] tools/hvmloader: Retrieve APIC IDs from the APs themselves Alejandro Vallejo
2025-02-04 14:45 ` [PATCH v2 2/2] tools/hvmloader: Replace LAPIC_ID() with cpu_to_apicid[] Alejandro Vallejo
2025-02-04 15:07   ` Jan Beulich [this message]
2025-02-04 15:25     ` Alejandro Vallejo
2025-02-04 15:46       ` Jan Beulich
2025-02-04 17:25         ` Alejandro Vallejo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84c8d20e-b9f1-4593-b5df-86cc00ff33b5@suse.com \
    --to=jbeulich@suse.com \
    --cc=alejandro.vallejo@cloud.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.