From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] usb: dwc2: change compatible st,stm32mp1-hsotg to st,stm32mp15-hsotg
Date: Wed, 10 Feb 2021 22:23:04 +0100 [thread overview]
Message-ID: <84ce2245-b731-41e0-7654-e8da7bf4332a@denx.de> (raw)
In-Reply-To: <a64dfb56-e43c-5adf-4c07-8935f900a47f@foss.st.com>
On 2/9/21 8:51 PM, Patrick DELAUNAY wrote:
>
> On 2/9/21 11:39 AM, Marek Vasut wrote:
>> On 2/9/21 11:14 AM, Patrick Delaunay wrote:
>> Hi,
>>
>> [...]
>>
>>> diff --git a/drivers/usb/gadget/dwc2_udc_otg.c
>>> b/drivers/usb/gadget/dwc2_udc_otg.c
>>> index e3871e381e..ecac80fc11 100644
>>> --- a/drivers/usb/gadget/dwc2_udc_otg.c
>>> +++ b/drivers/usb/gadget/dwc2_udc_otg.c
>>> @@ -1176,7 +1176,7 @@ static int dwc2_udc_otg_remove(struct udevice
>>> *dev)
>>> ? static const struct udevice_id dwc2_udc_otg_ids[] = {
>>> ????? { .compatible = "snps,dwc2" },
>>> ????? { .compatible = "brcm,bcm2835-usb" },
>>> -??? { .compatible = "st,stm32mp1-hsotg",
>>> +??? { .compatible = "st,stm32mp15-hsotg",
>>> ??????? .data = (ulong)dwc2_set_stm32mp1_hsotg_params },
>>
>> I have to point out the obvious, DT is ABI, this breaks ABI. However,
>> do we care about out-of-tree DTs here ?
>
>
> I know that the binding backward compatibility and "binary compatible"
> the is a key element of DT
>
> for the Linux kernel (for example the latest kernel image should work
> with a old device tree).
>
>
> I don't see the same requirement for U-Boot as external DT (with EXT_DTB
> option) is not common .
>
>
> So today I assume that U-Boot use only in-tree DT for stm32mp15
> platforms until we have a
>
> 100% upstream level of the stm32mp1 platform with binding aligned with
> Linux kernel bindings
>
> (for example we have some other pending issue for USBPHYC binding).
>
>
> But if backward compatibility is really blocking for U-Boot user, I can
> change my mind.
>
>
> PS: I correct a issue here, because I upstream the stm32mp downstream
> binding for dwc2,
>
> but this compatible had be modified before accepted by Linux kernel DT
> maintaineers
>
> => today USB in Linux kernel can't work with the DT used by U-Boot
All right, applied, thanks.
prev parent reply other threads:[~2021-02-10 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 10:14 [PATCH] usb: dwc2: change compatible st, stm32mp1-hsotg to st, stm32mp15-hsotg Patrick Delaunay
2021-02-09 10:39 ` [PATCH] usb: dwc2: change compatible st,stm32mp1-hsotg to st,stm32mp15-hsotg Marek Vasut
2021-02-09 19:51 ` Patrick DELAUNAY
2021-02-10 19:59 ` Tom Rini
2021-02-11 11:14 ` [Uboot-stm32] [PATCH] usb: dwc2: change compatible st, stm32mp1-hsotg to st, stm32mp15-hsotg Ahmad Fatoum
2021-02-11 13:02 ` Tom Rini
2021-02-12 13:29 ` Ahmad Fatoum
2021-02-19 13:30 ` Patrick DELAUNAY
2021-03-01 11:59 ` Ahmad Fatoum
2021-02-10 21:23 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84ce2245-b731-41e0-7654-e8da7bf4332a@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.