From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: harry <harry@hebutterworth.freeserve.co.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] fast_flush_area in blkback.c still broken after 55194bd55b86
Date: Mon, 7 Nov 2005 12:01:12 +0000 [thread overview]
Message-ID: <84d377e4d3479c5a9f2c51b95c0a3eea@cl.cam.ac.uk> (raw)
In-Reply-To: <1131362397.5955.11.camel@localhost.localdomain>
On 7 Nov 2005, at 11:19, harry wrote:
> I think you need this patch otherwise you will be passing uninitialised
> data from the stack to GNTTABOP_unmap_grant_ref in fast_flush_area.
>
> Also, I think the memset of the pending_grant_handles array should
> happen before you start using them so I moved it to before
> blkif_xenbus_init. I'm not sure if this is necessary or it might
> possibly have to go even earlier.
Two good catches. In fact the initialisation of pending_grant_handles
was more seriously broken -- the use of memset was bogus since the
array elements are u16's not u8's. So only half the array was being
initialised, and high byte of the initialiser value was discarded.
Where do we find these programmers.... :-)
-- Keir
prev parent reply other threads:[~2005-11-07 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-07 11:19 [PATCH] fast_flush_area in blkback.c still broken after 55194bd55b86 harry
2005-11-07 12:01 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d377e4d3479c5a9f2c51b95c0a3eea@cl.cam.ac.uk \
--to=keir.fraser@cl.cam.ac.uk \
--cc=harry@hebutterworth.freeserve.co.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.