From: Leon Hwang <leon.hwang@linux.dev>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Emil Tsalapatis <emil@etsalapatis.com>,
Shuah Khan <shuah@kernel.org>,
Jingguo Tan <tanjingguo@huawei.com>,
Pu Lehui <pulehui@huawei.com>, Lin Ma <malin89@huawei.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-patches-bot@fb.com
Subject: Re: [PATCH bpf-next 1/2] bpf: Fix WARNING in bpf_tracing_link_release
Date: Wed, 22 Jul 2026 22:44:42 +0800 [thread overview]
Message-ID: <84d3de0a-5d81-47eb-9e41-7107c0c15d70@linux.dev> (raw)
In-Reply-To: <amCnUg9xTo4kStW8@krava>
On 2026/7/22 19:19, Jiri Olsa wrote:
> On Tue, Jul 21, 2026 at 09:30:34PM +0800, Leon Hwang wrote:
>> The trampoline could be corrupted by the blindly
>> 'tr->flags = BPF_TRAMP_F_TAIL_CALL_CTX' in verifier.
>>
>> 1. A fexit attached to a tail_call_reachable prog.
>> 2. Another fexit loaded with the same tail_call_reachable prog target.
>> 3. Close the first fexit link.
>
> had to ask ai for more details on how the warning was trigered ;-)
> would be nice to have that info in the changelog
Ack.
Will add the change of tr->flags. So, the detach failure would be
obvious due to the incorrect tr->flags.
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks for your review.
Leon
> [...]
next prev parent reply other threads:[~2026-07-22 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 13:30 [PATCH bpf-next 0/2] bpf: Fix WARNING in bpf_tracing_link_release Leon Hwang
2026-07-21 13:30 ` [PATCH bpf-next 1/2] " Leon Hwang
2026-07-22 11:19 ` Jiri Olsa
2026-07-22 14:44 ` Leon Hwang [this message]
2026-07-21 13:30 ` [PATCH bpf-next 2/2] selftests/bpf: Verify no warning when close fexit link Leon Hwang
2026-07-22 11:20 ` Jiri Olsa
2026-07-22 14:45 ` Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d3de0a-5d81-47eb-9e41-7107c0c15d70@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-patches-bot@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=malin89@huawei.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=olsajiri@gmail.com \
--cc=pulehui@huawei.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanjingguo@huawei.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.