All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Mike Galbraith <efault@gmx.de>, Breno Leitao <leitao@debian.org>,
	Simon Horman <horms@kernel.org>,
	kuba@kernel.org, calvin@wbinvd.org
Cc: Pavel Begunkov <asml.silence@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	paulmck@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, boqun.feng@gmail.com
Subject: Re: netconsole: HARDIRQ-safe -> HARDIRQ-unsafe lock order warning
Date: Mon, 08 Sep 2025 15:36:17 +0206	[thread overview]
Message-ID: <84frcx842e.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <7fc8a1db60de959fd22ae898e86683f57fb07be2.camel@gmx.de>

On 2025-09-06, Mike Galbraith <efault@gmx.de> wrote:
>> The ->write_atomic() callback is intended to perform immediate
>> transmission. It is called with hardware interrupts disabled and is even
>> expected to work from NMI context. If you are not able to implement
>> these requirements, do not implement ->write_atomic(). Implementing some
>> sort of deferrment mechanism is inappropriate. Such a mechanism already
>> exists based on ->write_thread().
>
> Truly atomic packet blasting would be a case of happiness, but barring
> that, deferment is way better than the nothing that's available to both
> RT and !RT+wireless here/now.  With a .write_atomic that's really just
> .write_thread, both RT and !RT+wireless managed to successfully send a
> death rattle with the WIP nbcon patch.. a progression for each of them.

Just be aware that ->write_atomic() will be called from _any_ context
(including scheduler and NMI) and a console implementing this callback
must handle the message or the message is lost for that console.

I request that I am added CC to the next incarnation of this
series. Thanks!

John Ogness

  reply	other threads:[~2025-09-08 13:30 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13  4:14 netconsole: HARDIRQ-safe -> HARDIRQ-unsafe lock order warning Mike Galbraith
2025-08-14 10:16 ` Breno Leitao
2025-08-14 15:45   ` Pavel Begunkov
2025-08-15  0:23   ` Jakub Kicinski
2025-08-15 10:44     ` Pavel Begunkov
2025-08-15 16:42       ` Jakub Kicinski
2025-08-15 17:29         ` Breno Leitao
2025-08-15 17:33           ` Jakub Kicinski
2025-08-18 12:23             ` Breno Leitao
2025-08-15 19:10           ` Calvin Owens
2025-08-16  9:19             ` Mike Galbraith
2025-08-15 20:02           ` Pavel Begunkov
2025-08-18 12:10             ` Breno Leitao
2025-08-19 17:27               ` Breno Leitao
2025-08-20 12:31                 ` Mike Galbraith
2025-08-20 17:36                   ` Breno Leitao
2025-08-21  3:37                     ` Mike Galbraith
2025-08-21  3:51                       ` Mike Galbraith
2025-08-21 17:35                         ` Breno Leitao
2025-08-22  3:54                           ` Mike Galbraith
2025-08-26 12:43                             ` Breno Leitao
2025-08-26 13:56                               ` Mike Galbraith
2025-09-05 12:48                               ` John Ogness
2025-09-06  2:32                                 ` Mike Galbraith
2025-09-08 13:30                                   ` John Ogness [this message]
2025-09-08 15:18                                     ` Mike Galbraith
2025-09-08 20:27                                 ` Calvin Owens
2025-09-09 15:49                                   ` Mike Galbraith
2025-09-10 15:51                                   ` Petr Mladek
2025-09-09 12:50                                 ` Breno Leitao
2025-09-10 12:22                                   ` John Ogness
2025-09-10 15:12                                     ` Petr Mladek
2025-09-10 18:26                                       ` Breno Leitao
2025-09-30 13:57                                         ` Calvin Owens
2025-09-30 14:23                                           ` John Ogness
2025-09-30 14:30                                             ` Sebastian Siewior
2025-09-30 17:35                                               ` Mike Galbraith
2025-10-01  6:00                                                 ` Mike Galbraith
2025-09-11 13:03                                       ` John Ogness
2025-09-10 18:23                                     ` Breno Leitao
2025-09-11 13:13                                       ` John Ogness
2025-08-21 10:06                       ` Mike Galbraith
2025-08-21 13:12                         ` Mike Galbraith
2025-08-15 17:37         ` Calvin Owens
2025-08-26 14:10         ` Johannes Berg
2025-08-15 12:45     ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84frcx842e.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=asml.silence@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=calvin@wbinvd.org \
    --cc=efault@gmx.de \
    --cc=horms@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.