All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Peter.Chubb@data61.csiro.au>
To: alistair.francis@xilinx.com
Cc: qemu-devel@nongnu.org, alistair23@gmail.com,
	philippe@mathieu-daude.net, berrange@redhat.com,
	armbru@redhat.com, jcody@redhat.com, kwolf@redhat.com,
	mreitz@redhat.com, ronniesahlberg@gmail.com, pbonzini@redhat.com,
	pl@kamp.de, jdurgin@redhat.com, rjones@redhat.com,
	crosthwaite.peter@gmail.com, rth@twiddle.net,
	aneesh.kumar@linux.vnet.ibm.com, groug@kaod.org, robh@kernel.org,
	peter.maydell@linaro.org, peter.chubb@nicta.com.au,
	ehabkost@redhat.com, marcel@redhat.com, mst@redhat.com,
	imammedo@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de,
	kraxel@redhat.com, jasowang@redhat.com, mtosatti@redhat.com,
	borntraeger@de.ibm.com, cohuck@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/8] Convert error_report() to warn_report()
Date: Fri, 7 Jul 2017 23:35:00 +0000	[thread overview]
Message-ID: <84tw2nbz31.wl-Peter.Chubb@data61.csiro.au> (raw)
In-Reply-To: <125868e788f5705e31c0326bed02bc75f9fb173e.1499453788.git.alistair.francis@xilinx.com>

>>>>> "Alistair" == Alistair Francis <alistair.francis@xilinx.com> writes:

Alistair> Convert all uses of error_report("[Ww]arning:"... to use
Alistair> warn_report() instead. This helps standardise on a single
Alistair> method of printing warnings to the user.

Alistair> All of the warnings were changed using this command: find
Alistair> ./* -type f -exec sed -i \ 's|error_report.*[Ww]arning:
Alistair> |warn_report("|g' {} +

Alistair> Then the white space changes where manually fixed
Alistair> afterwards.

s/where/were/

Otherwise,
	Reviewed by: Peter Chubb <peter.chubb@data61.csiro.au>
(for KZM and i.mx25 parts; I did look at the other bits but didn't see
	anything obviously crazy.)

-- 
Dr Peter Chubb         Tel: +61 2 9490 5852      http://ts.data61.csiro.au/
Trustworthy Systems Group                           Data61 (formerly NICTA)

  reply	other threads:[~2017-07-08  1:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 23:20 [Qemu-devel] [PATCH v2 0/8] Implement a warning_report function Alistair Francis
2017-07-07 23:20 ` [Qemu-devel] [PATCH v2 1/8] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-07-07 23:21 ` [Qemu-devel] [PATCH v2 2/8] error: Functions to report warnings and informational messages Alistair Francis
2017-07-10 12:56   ` Markus Armbruster
2017-07-07 23:21 ` [Qemu-devel] [PATCH v2 3/8] Convert error_report() to warn_report() Alistair Francis
2017-07-07 23:35   ` Peter.Chubb [this message]
2017-07-09 18:30   ` Max Reitz
2017-07-10 13:24   ` Markus Armbruster
2017-07-07 23:21 ` [Qemu-devel] [PATCH v2 4/8] hw/i386: Improve some of the warning messages Alistair Francis
2017-07-07 23:21 ` [Qemu-devel] [PATCH v2 5/8] char-socket: Report TCP socket waiting as information Alistair Francis
2017-07-07 23:21 ` [Qemu-devel] [PATCH v2 6/8] error: Implement the warn and free Error functions Alistair Francis
2017-07-10 13:39   ` Markus Armbruster
2017-07-07 23:21 ` [Qemu-devel] [PATCH v2 7/8] Convert error_report*_err() to warn_report*_err() Alistair Francis
2017-07-10 13:43   ` Markus Armbruster
2017-07-07 23:21 ` [Qemu-devel] [PATCH v2 8/8] error: Add a 'error: ' prefix to error_report() Alistair Francis
2017-07-08  4:36   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84tw2nbz31.wl-Peter.Chubb@data61.csiro.au \
    --to=peter.chubb@data61.csiro.au \
    --cc=agraf@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jdurgin@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=philippe@mathieu-daude.net \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=robh@kernel.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.