All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: jerinj@marvell.com
Cc: dev@dpdk.org, olivier.matz@6wind.com,
	mattias.ronnblom@ericsson.com, Jerin Jacob <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] doc: use glob terminology
Date: Sun, 12 Apr 2020 17:05:22 +0200	[thread overview]
Message-ID: <8516363.EvYhyI6sBW@thomas> (raw)
In-Reply-To: <20200412144047.2125201-1-jerinj@marvell.com>

12/04/2020 16:40, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Globbing is the word used on fnmatch man page. Use globing
> terminology accross dpdk repo for shell pattern.
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
[...]
> --- a/lib/librte_eal/include/rte_log.h
> +++ b/lib/librte_eal/include/rte_log.h
> - * Set the log level for a given type based on shell pattern.
> + * Set the log level for a given type based on globbing.
>   *
>   * @param pattern
>   *   The match pattern identifying the log type.

"match pattern" can be replaced with "globbing pattern".

I think there are few other places which can be improved.

I see this one in lib/librte_eal/common/eal_common_log.c:
	glob (file match) pattern
I suggest "globbing pattern"

And "Glob match string option" -> "Globbing pattern option"



      parent reply	other threads:[~2020-04-12 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-12 14:40 [dpdk-dev] [PATCH] doc: use glob terminology jerinj
2020-04-12 15:04 ` [dpdk-dev] [PATCH v2] " jerinj
2020-04-25 17:26   ` Thomas Monjalon
2020-05-04 13:45   ` [dpdk-dev] [PATCH v3] " jerinj
2020-05-19 14:05     ` Thomas Monjalon
2020-04-12 15:05 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8516363.EvYhyI6sBW@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.