From: Roman Mashak <mrv@mojatatu.com>
To: netdev@vger.kernel.org
Cc: jiri@mellanox.com, Jamal Hadi Salim <jhs@mojatatu.com>
Subject: broken behaviour of TC filter delete
Date: Thu, 23 Aug 2018 17:39:22 -0400 [thread overview]
Message-ID: <851sao225x.fsf@mojatatu.com> (raw)
It appears that the following commit changed the behaviour of scenario where a
filter is deleted twice:
commit f71e0ca4db187af7c44987e9d21e9042c3046070
Author: Jiri Pirko <jiri@mellanox.com>
Date: Mon Jul 23 09:23:05 2018 +0200
net: sched: Avoid implicit chain 0 creation
Steps to reproduce :
1) create dummy device
$ ip link add dev dummy0 type dummy
2) create qdisc
$ tc qdisc add dev dummy0 ingress
3) create simple u32 filter with action attached
$ tc filter add dev dummy0 parent ffff: protocol ip prio 1 u32 match ip src 10.10.10.1/32 action ok
4) list the filter
$ tc filter ls dev dummy0 parent ffff:
5) delete the filter with the given protocol and priority
$ tc filter del dev dummy0 parent ffff: protocol ip prio 1
6) repeat step 5, this will return -ENOENT ("Error: Filter with specified priority/protocol not found.")
However, before the change at step 6 we would get -EINVAL (Error: Cannot find specified filter chain.)
and that makes sense.
The change breaks a number of our internal TC tests.
next reply other threads:[~2018-08-24 1:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 21:39 Roman Mashak [this message]
2018-08-24 8:17 ` broken behaviour of TC filter delete Jiri Pirko
2018-08-24 16:18 ` Roman Mashak
2018-08-24 18:11 ` Cong Wang
2018-08-25 13:02 ` Jiri Pirko
2018-08-26 17:48 ` Jamal Hadi Salim
2018-08-27 18:30 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=851sao225x.fsf@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.