From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Mashak Subject: Re: [PATCH net 1/5] net sched actions: fix coding style in pedit action Date: Wed, 20 Jun 2018 09:25:37 -0400 Message-ID: <851sd1fv3i.fsf@mojatatu.com> References: <1529427368-17129-1-git-send-email-mrv@mojatatu.com> <1529427368-17129-2-git-send-email-mrv@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: Davide Caratti Return-path: Received: from mail-it0-f66.google.com ([209.85.214.66]:51440 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754055AbeFTNZj (ORCPT ); Wed, 20 Jun 2018 09:25:39 -0400 Received: by mail-it0-f66.google.com with SMTP id n7-v6so5369398itn.1 for ; Wed, 20 Jun 2018 06:25:39 -0700 (PDT) In-Reply-To: (Davide Caratti's message of "Wed, 20 Jun 2018 14:29:43 +0200") Sender: netdev-owner@vger.kernel.org List-ID: Davide Caratti writes: > On Tue, 2018-06-19 at 12:56 -0400, Roman Mashak wrote: >> Fix coding style issues in tc pedit action detected by the >> checkpatch script. >> >> Signed-off-by: Roman Mashak > ... > >> --- >> @@ -316,16 +318,15 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, >> hoffset + tkey->at); >> goto bad; >> } >> - d = skb_header_pointer(skb, hoffset + tkey->at, 1, >> - &_d); >> + d = skb_header_pointer(skb, hoffset + tkey->at, >> + 1, &_d); >> if (!d) >> goto bad; >> offset += (*d & tkey->offmask) >> tkey->shift; >> } > > hello Roman, > > nit: while we are here, what about changing the declaration of _d and *d > to u8, so that the bitwise operation is done on unsigned? Yes makes sense, I will send v2 in net-next once opened. Thanks Davide. > BTW: the patch (and the series) looks ok, but I guess it will better > target net-next when the branch reopens