Re: [PATCH] eal/linux: fix build

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

Hi Michael,

2015-03-05 09:13, Qiu, Michael:
> On 3/4/2015 6:24 AM, Thomas Monjalon wrote:
> >>> Compilation fails in some distributions because of missing unistd.h
> >>> needed for pread/pwrite (seen with Suse):
> >>>         lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
> >>>         error: implicit declaration of function ‘pread’
> >>>
> >>> Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support")
> >>>
> >>> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> >> Acked-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > Applied
> 
> Hi, Thomas
> 
> This patch may be need to be reverted, as the error still exists.

No I don't think it should be reverted. It must be completed.

[...]
> NAME
>        pread, pwrite - read from or write to a file descriptor at a
> given offset
> 
> SYNOPSIS
>        #define _XOPEN_SOURCE 500
> 
>        #include <unistd.h>
[...]
> While I try to add marco #define _XOPEN_SOURCE 500

I think that the good thing to do.

> Other errors show up

Are they hard to fix?

> Who knows how to solve this issue?