From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] ARM: dts: rockchip: Add dp83867 CLK_OUT muxing Date: Mon, 05 Mar 2018 18:04:48 +0100 Message-ID: <8543411.nbQLj7Vctj@diego> References: <1520253911-46218-1-git-send-email-d.schultz@phytec.de> <3530074.WSbKf9j6h0@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Daniel Schultz Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, w.egorov@phytec.de, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org Hi Daniel, Am Montag, 5. M=E4rz 2018, 16:57:13 CET schrieb Daniel Schultz: > On 03/05/2018 03:15 PM, Heiko Stuebner wrote: > > Am Montag, 5. M=E4rz 2018, 13:45:11 CET schrieb Daniel Schultz: > >> The CLK_O_SEL default is synchronous to XI input clock, which is 25 MH= z. > >> Set CLK_O_SEL to channel A transmit clock so we have 125 MHz on CLK_OU= T. > >> = > >> Signed-off-by: Daniel Schultz > >> --- > >> = > >> The binding will be added with the next merge of net-next: > >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/com= mit > >> /?id=3D9708fb630d19ee51ae3aeb3a533e3010da0e8570 > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/Do= cum > entation/devicetree/bindings/net/ti,dp83867.txt > = > If I search in the master branch, I get the patch. Did I searched wrong? no ... seems I was just blind :-) Heiko > > I did find the commit, but no related change of the dp83867 dt binding > > document [0], including a review by dt-maintainers. > > = > > While your property does not look overly complicated, the binding > > should be updated nontheless. > > = > > = > > Heiko > > = > > [0] > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/= Do > > cumentation/devicetree/bindings/net/ti,dp83867.txt?id=3D9708fb630d19ee5= 1ae3a > > eb3a533e3010da0e8570> = > >> arch/arm/boot/dts/rk3288-phycore-som.dtsi | 1 + > >> 1 file changed, 1 insertion(+) > >> = > >> diff --git a/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> b/arch/arm/boot/dts/rk3288-phycore-som.dtsi index bdd80aa..e60535d > >> 100644 > >> --- a/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> +++ b/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> @@ -141,6 +141,7 @@ > >> = > >> ti,tx-internal-delay =3D ; > >> ti,fifo-depth =3D ; > >> enet-phy-lane-no-swap; > >> = > >> + ti,clk-output-sel =3D ; > >> = > >> }; > >> = > >> }; > >> = > >> }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Mon, 05 Mar 2018 18:04:48 +0100 Subject: [PATCH] ARM: dts: rockchip: Add dp83867 CLK_OUT muxing In-Reply-To: References: <1520253911-46218-1-git-send-email-d.schultz@phytec.de> <3530074.WSbKf9j6h0@phil> Message-ID: <8543411.nbQLj7Vctj@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Daniel, Am Montag, 5. M?rz 2018, 16:57:13 CET schrieb Daniel Schultz: > On 03/05/2018 03:15 PM, Heiko Stuebner wrote: > > Am Montag, 5. M?rz 2018, 13:45:11 CET schrieb Daniel Schultz: > >> The CLK_O_SEL default is synchronous to XI input clock, which is 25 MHz. > >> Set CLK_O_SEL to channel A transmit clock so we have 125 MHz on CLK_OUT. > >> > >> Signed-off-by: Daniel Schultz > >> --- > >> > >> The binding will be added with the next merge of net-next: > >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit > >> /?id=9708fb630d19ee51ae3aeb3a533e3010da0e8570 > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/Docum > entation/devicetree/bindings/net/ti,dp83867.txt > > If I search in the master branch, I get the patch. Did I searched wrong? no ... seems I was just blind :-) Heiko > > I did find the commit, but no related change of the dp83867 dt binding > > document [0], including a review by dt-maintainers. > > > > While your property does not look overly complicated, the binding > > should be updated nontheless. > > > > > > Heiko > > > > [0] > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/Do > > cumentation/devicetree/bindings/net/ti,dp83867.txt?id=9708fb630d19ee51ae3a > > eb3a533e3010da0e8570> > >> arch/arm/boot/dts/rk3288-phycore-som.dtsi | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> b/arch/arm/boot/dts/rk3288-phycore-som.dtsi index bdd80aa..e60535d > >> 100644 > >> --- a/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> +++ b/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> @@ -141,6 +141,7 @@ > >> > >> ti,tx-internal-delay = ; > >> ti,fifo-depth = ; > >> enet-phy-lane-no-swap; > >> > >> + ti,clk-output-sel = ; > >> > >> }; > >> > >> }; > >> > >> }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752669AbeCERU0 convert rfc822-to-8bit (ORCPT ); Mon, 5 Mar 2018 12:20:26 -0500 Received: from gloria.sntech.de ([95.129.55.99]:38768 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110AbeCERUY (ORCPT ); Mon, 5 Mar 2018 12:20:24 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Schultz Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, w.egorov@phytec.de Subject: Re: [PATCH] ARM: dts: rockchip: Add dp83867 CLK_OUT muxing Date: Mon, 05 Mar 2018 18:04:48 +0100 Message-ID: <8543411.nbQLj7Vctj@diego> In-Reply-To: References: <1520253911-46218-1-git-send-email-d.schultz@phytec.de> <3530074.WSbKf9j6h0@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Am Montag, 5. März 2018, 16:57:13 CET schrieb Daniel Schultz: > On 03/05/2018 03:15 PM, Heiko Stuebner wrote: > > Am Montag, 5. März 2018, 13:45:11 CET schrieb Daniel Schultz: > >> The CLK_O_SEL default is synchronous to XI input clock, which is 25 MHz. > >> Set CLK_O_SEL to channel A transmit clock so we have 125 MHz on CLK_OUT. > >> > >> Signed-off-by: Daniel Schultz > >> --- > >> > >> The binding will be added with the next merge of net-next: > >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit > >> /?id=9708fb630d19ee51ae3aeb3a533e3010da0e8570 > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/Docum > entation/devicetree/bindings/net/ti,dp83867.txt > > If I search in the master branch, I get the patch. Did I searched wrong? no ... seems I was just blind :-) Heiko > > I did find the commit, but no related change of the dp83867 dt binding > > document [0], including a review by dt-maintainers. > > > > While your property does not look overly complicated, the binding > > should be updated nontheless. > > > > > > Heiko > > > > [0] > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/Do > > cumentation/devicetree/bindings/net/ti,dp83867.txt?id=9708fb630d19ee51ae3a > > eb3a533e3010da0e8570> > >> arch/arm/boot/dts/rk3288-phycore-som.dtsi | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> b/arch/arm/boot/dts/rk3288-phycore-som.dtsi index bdd80aa..e60535d > >> 100644 > >> --- a/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> +++ b/arch/arm/boot/dts/rk3288-phycore-som.dtsi > >> @@ -141,6 +141,7 @@ > >> > >> ti,tx-internal-delay = ; > >> ti,fifo-depth = ; > >> enet-phy-lane-no-swap; > >> > >> + ti,clk-output-sel = ; > >> > >> }; > >> > >> }; > >> > >> };